Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update code owners #925

Merged
merged 2 commits into from
Mar 15, 2024
Merged

docs: update code owners #925

merged 2 commits into from
Mar 15, 2024

Conversation

mkbreuningIOHK
Copy link
Contributor

Description:

  • Code owners: the content editor will be automatically added to any PR related to markdown files
  • Code owners: update to the current team
  • Pull request template: add the link to the contributing guideline
  • Issue template: update an old link

Checklist:

  • My PR follows the contribution guidelines of this project
  • [] My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mkbreuningIOHK
docs: update code owners
b4bfbb9 
Signed-off-by: MICHAEL BREUNINGER <michael.breuninger@iohk.io>
@atala-dev atala-dev added the ci label Mar 14, 2024
@mkbreuningIOHK
Copy link
Contributor Author

@yshyn-iohk @mineme0110 , for the code owners, it is listing some directories but what about the ones that are not listed? It means there is no default owner?
The list is: event-notification, examples, infrastructure, mercury, project, shared-test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f45f0c. ± Comparison against base commit 7163c94.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

Unit Test Results

 88 files  ±0   88 suites  ±0   20m 22s ⏱️ + 1m 40s
761 tests ±0  753 ✅ ±0  8 💤 ±0  0 ❌ ±0 
768 runs  ±0  760 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 1f45f0c. ± Comparison against base commit 7163c94.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mkbreuningIOHK mkbreuningIOHK merged commit 3eb0a11 into main Mar 15, 2024
11 checks passed
@mkbreuningIOHK mkbreuningIOHK deleted the oea-update-codeowners branch March 15, 2024 07:59
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@mkbreuningIOHK @mineme0110
docs: update code owners (#925)
6dd4fb7 
Signed-off-by: MICHAEL BREUNINGER <michael.breuninger@iohk.io>
Co-authored-by: Shailesh Patil <53746241+mineme0110@users.noreply.github.com>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@mkbreuningIOHK @mineme0110
docs: update code owners (#925)
c061cc2 
Signed-off-by: MICHAEL BREUNINGER <michael.breuninger@iohk.io>
Co-authored-by: Shailesh Patil <53746241+mineme0110@users.noreply.github.com>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@mkbreuningIOHK @mineme0110
docs: update code owners (#925)
0fc591c 
Signed-off-by: MICHAEL BREUNINGER <michael.breuninger@iohk.io>
Co-authored-by: Shailesh Patil <53746241+mineme0110@users.noreply.github.com>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@mineme0110 mineme0110 mineme0110 approved these changes

@bvoiturier bvoiturier bvoiturier approved these changes

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkbreuningIOHK @bvoiturier @mineme0110 @yshyn-iohk @atala-dev