Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(adr): ATL-6599 update ADR based on first implementation experience #952

Merged
merged 10 commits into from
Apr 11, 2024
Merged

docs(adr): ATL-6599 update ADR based on first implementation experience #952

merged 10 commits into from
Apr 11, 2024

Conversation

bvoiturier
Copy link
Contributor

Description:

ATL-6603 part of ATL-6599

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@bvoiturier
chore(connect): minor code cleanup
39ee000 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
docs(adr): upgrade ADR based on implementation experience
a3b7e71 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Integration Test Results

13 files  ±0  13 suites  ±0   2s ⏱️ ±0s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
32 runs  ±0  32 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a3b6615. ± Comparison against base commit e1c2a51.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Unit Test Results

 90 files  ±0   90 suites  ±0   20m 39s ⏱️ -19s
776 tests ±0  768 ✅ ±0  8 💤 ±0  0 ❌ ±0 
783 runs  ±0  775 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a3b6615. ± Comparison against base commit e1c2a51.

♻️ This comment has been updated with latest results.

petevielhaber
petevielhaber requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@petevielhaber petevielhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Minor grammar fixes

bvoiturier and others added 4 commits March 29, 2024 09:56
@bvoiturier @petevielhaber
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
cc51055 
…ly.md

Co-authored-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Signed-off-by: bvoiturier <benjamin.voiturier@iohk.io>
@bvoiturier @petevielhaber
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
236c5fb 
…ly.md

Co-authored-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Signed-off-by: bvoiturier <benjamin.voiturier@iohk.io>
@bvoiturier @petevielhaber
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
17fa167 
…ly.md

Co-authored-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Signed-off-by: bvoiturier <benjamin.voiturier@iohk.io>
@bvoiturier @petevielhaber
Apply grammatical improvements suggested in code review
10cd7a2 
Co-authored-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Signed-off-by: bvoiturier <benjamin.voiturier@iohk.io>
bvoiturier
bvoiturier commented Mar 29, 2024
View reviewed changes
Copy link
Contributor Author

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your review, @petevielhaber! I accepted almost all suggestions but left a comment for 3 of them. Could you review?

docs/decisions/20240116-use-zio-failures-and-defects-effectively.md Outdated Show resolved Hide resolved
docs/decisions/20240116-use-zio-failures-and-defects-effectively.md Outdated Show resolved Hide resolved
docs/decisions/20240116-use-zio-failures-and-defects-effectively.md Outdated Show resolved Hide resolved
@bvoiturier
docs(adr): update ADR status and date
7698b50 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
docs(adr): grammar fixes
c787284 
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
@bvoiturier
Merge branch 'main' into docs/ATL-6599-update-adr-based-on-first-impl…
eb6b649 
…ementation-experience
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

patlo-iog
patlo-iog approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@patlo-iog patlo-iog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 👍

@bvoiturier bvoiturier merged commit 32cd9e6 into main Apr 11, 2024
9 checks passed
@bvoiturier bvoiturier deleted the docs/ATL-6599-update-adr-based-on-first-implementation-experience branch April 11, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patlo-iog patlo-iog patlo-iog approved these changes

@petevielhaber petevielhaber petevielhaber approved these changes

@shotexa shotexa Awaiting requested review from shotexa

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
connect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvoiturier @petevielhaber @patlo-iog @atala-dev