Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(adr): ATL-6599 update ADR based on first implementation experience #952

Merged
merged 10 commits into from
Apr 11, 2024
Merged

docs(adr): ATL-6599 update ADR based on first implementation experience #952

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
39ee000
chore(connect): minor code cleanup
bvoiturier Mar 28, 2024
a3b7e71
docs(adr): upgrade ADR based on implementation experience
bvoiturier Mar 28, 2024
cc51055
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
bvoiturier Mar 29, 2024
236c5fb
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
bvoiturier Mar 29, 2024
17fa167
Update docs/decisions/20240116-use-zio-failures-and-defects-effective…
bvoiturier Mar 29, 2024
10cd7a2
Apply grammatical improvements suggested in code review
bvoiturier Mar 29, 2024
7698b50
docs(adr): update ADR status and date
bvoiturier Mar 29, 2024
c787284
docs(adr): grammar fixes
bvoiturier Mar 29, 2024
eb6b649
Merge branch 'main' into docs/ATL-6599-update-adr-based-on-first-impl…
bvoiturier Mar 29, 2024
a3b6615
Merge branch 'main' into docs/ATL-6599-update-adr-based-on-first-impl…
bvoiturier Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...ore/src/main/scala/io/iohk/atala/connect/core/model/error/ConnectionRepositoryError.scala
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...e/src/main/scala/io/iohk/atala/connect/core/repository/ConnectionRepositoryInMemory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package io.iohk.atala.connect.core.repository

import io.iohk.atala.connect.core.model.ConnectionRecord
import io.iohk.atala.connect.core.model.ConnectionRecord.ProtocolState
import io.iohk.atala.connect.core.model.error.ConnectionRepositoryError.*
import io.iohk.atala.mercury.protocol.connection.ConnectionRequest
import io.iohk.atala.mercury.protocol.connection.ConnectionResponse
import io.iohk.atala.shared.models.WalletAccessContext
Expand Down
2 changes: 1 addition & 1 deletion ...ct/lib/core/src/main/scala/io/iohk/atala/connect/core/service/ConnectionServiceImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ private class ConnectionServiceImpl(
)
maybeRecord <- connectionRepository
.findById(record.id)
record <- ZIO.getOrFailWith(new RecordIdNotFound(recordId))(maybeRecord)
record <- ZIO.getOrFailWith(RecordIdNotFound(recordId))(maybeRecord)
} yield record

override def markConnectionRequestSent(
Expand Down
1 change: 0 additions & 1 deletion .../src/test/scala/io/iohk/atala/connect/core/repository/ConnectionRepositorySpecSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package io.iohk.atala.connect.core.repository

import io.iohk.atala.connect.core.model.ConnectionRecord
import io.iohk.atala.connect.core.model.ConnectionRecord.*
import io.iohk.atala.connect.core.model.error.ConnectionRepositoryError.*
import io.iohk.atala.mercury.model.DidId
import io.iohk.atala.mercury.protocol.connection.{ConnectionRequest, ConnectionResponse}
import io.iohk.atala.mercury.protocol.invitation.v2.Invitation
Expand Down
Loading
Loading