Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SD-JWT verification #208

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: SD-JWT verification #208

wants to merge 25 commits into from

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Sep 25, 2024 •
edited
Loading

Description:

This PR brings SD-JWT verification across SDKs.

Breaking change: Deprecated createJWTPresentationSubmission and createAnoncredsPresentationSubmission

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@cristianIOHK
feat: verification sd-jwt
51aa7d4 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: verify jwt verification after changes
2ca7155 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
Merge branch 'main' into feature/ATL-6862
12dec3f 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: request credential support for SD-JWT
9e351e1 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: verification sd-jwt
cf9e827 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
Merge branch 'main' into feature/ATL-6862
5ae06cb 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: SD-JWT verification
63f547b 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: SD-JWT verification
38a2fc6 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: SD-JWT verification ready to test
4b77970 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
refactor: clean up code, remove deprecated unit tests
877e948 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
breaking change: remove deprecated methods
51f4948 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
Merge branch 'main' into feature/ATL-6862
9b4c0b9 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Unit Test Results

0 tests   - 152   0 ✅  - 149   0s ⏱️ -7s
0 suites  -  26   0 💤  -   3 
0 files    -  26   0 ❌ ±  0 

Results for commit 42132a3. ± Comparison against base commit fce300e.

♻️ This comment has been updated with latest results.

@cristianIOHK
fix: linting issues
490e970 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
fix: linting issues
e052705 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
fix: linting issues
5355e93 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
fix: linting issues
e729ac6 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
fix: linting issues
7165cb2 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK cristianIOHK marked this pull request as ready for review September 25, 2024 19:43
@cristianIOHK
feat: create prism did with Ed25519
0e1feaf 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@cristianIOHK
feat: prism did support for Ed25519
462e44e 
Signed-off-by: Cristian G <cristian.castro@iohk.io>
@elribonazo elribonazo linked an issue Oct 30, 2024 that may be closed by this pull request
Support Verification in SDK - SD-JWT-VC #214
Open
@elribonazo
fix: Edge Agent should not be calling Apollo classes directly but Apo…
553247c 
…llo instead

fix: code improvements to allow passing additional authentication keys to Castor.createPrismDID
@elribonazo elribonazo requested a review from a team as a code owner November 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

@curtis-h curtis-h Awaiting requested review from curtis-h

@elribonazo elribonazo Awaiting requested review from elribonazo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Verification in SDK - SD-JWT-VC
2 participants
@cristianIOHK @elribonazo