From 578a67559b0e3e0e5fb9d92c76da50c544145e14 Mon Sep 17 00:00:00 2001 From: Allain Magyar Date: Sat, 27 Apr 2024 12:11:44 -0300 Subject: [PATCH 1/5] test: fix e2e cloud client dependency --- tests/end-to-end/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/end-to-end/build.gradle.kts b/tests/end-to-end/build.gradle.kts index 804c54740..d8bc6de39 100644 --- a/tests/end-to-end/build.gradle.kts +++ b/tests/end-to-end/build.gradle.kts @@ -19,7 +19,7 @@ repositories { } } maven { - url = uri("https://maven.pkg.github.com/hyperledger-labs/open-enterprise-agent/") + url = uri("https://maven.pkg.github.com/hyperledger/identus-cloud-agent/") credentials { username = System.getenv("ATALA_GITHUB_ACTOR") password = System.getenv("ATALA_GITHUB_TOKEN") From fbbdf5d4b4ff7b66b6ba4efe7d3c71fa6fc82af4 Mon Sep 17 00:00:00 2001 From: Allain Magyar Date: Sat, 27 Apr 2024 12:13:03 -0300 Subject: [PATCH 2/5] chore: update pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a5acc4459..bf6349392 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,9 +6,9 @@ Link to any discussion, related issues and bug reports to give the context to he Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas. ### Checklist: -- [] My PR follows the [contribution guidelines](https://github.com/input-output-hk/atala-prism-wallet-sdk-kmm/blob/main/CONTRIBUTING.md) of this project -- [] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) -- [] I have commented my code, particularly in hard-to-understand areas -- [] I have made corresponding changes to the documentation -- [] I have added tests that prove my fix is effective or that my feature works -- [] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) \ No newline at end of file +- [ ] My PR follows the [contribution guidelines](https://github.com/input-output-hk/atala-prism-wallet-sdk-kmm/blob/main/CONTRIBUTING.md) of this project +- [ ] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) From facf3388a3610909328920ce6c957eafa2a3f374 Mon Sep 17 00:00:00 2001 From: Allain Magyar Date: Sat, 27 Apr 2024 12:40:57 -0300 Subject: [PATCH 3/5] test: add e2e build to ci Signed-off-by: Allain Magyar --- .github/workflows/build-and-test.yml | 6 ++-- .github/workflows/e2e-build.yml | 41 ++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/e2e-build.yml diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 7d2097eb1..d6c0e7e42 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -6,14 +6,14 @@ defaults: shell: bash concurrency: - group: ${{ github.head_ref }}${{ github.ref }} + group: "${{ github.head_ref }}${{ github.ref }}" cancel-in-progress: true env: JAVA_VERSION: 17 NODEJS_VERSION: 16.17.0 - ATALA_GITHUB_ACTOR: ${{ secrets.ATALA_GITHUB_ACTOR }} - ATALA_GITHUB_TOKEN: ${{ secrets.ATALA_GITHUB_TOKEN }} + ATALA_GITHUB_ACTOR: ${{ secrets.GITHUB_TOKEN }} + ATALA_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} on: push: diff --git a/.github/workflows/e2e-build.yml b/.github/workflows/e2e-build.yml new file mode 100644 index 000000000..6158a76e9 --- /dev/null +++ b/.github/workflows/e2e-build.yml @@ -0,0 +1,41 @@ +name: End-to-end tests + +concurrency: + group: ${{ github.head_ref }}${{ github.ref }}-e2e-build + cancel-in-progress: true + +on: + pull_request: + branches: + - main + +env: + JAVA_VERSION: 17 + NODEJS_VERSION: 16.17.0 + ATALA_GITHUB_ACTOR: ${{ secrets.GITHUB_TOKEN }} + ATALA_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + +jobs: + run-e2e-tests: + name: 'Build e2e tests' + runs-on: ubuntu-latest + + steps: + - name: Install Java ${{ env.JAVA_VERSION }} + uses: actions/setup-java@v3 + with: + java-version: "${{ env.JAVA_VERSION }}" + distribution: 'adopt' + + - name: Checkout Code + uses: actions/checkout@v4 + + - name: Gradle Build Action + uses: gradle/gradle-build-action@v2 + + - name: Publish to maven local + run: ./gradlew publishToMavenLocal + + - name: Run e2e build + working-directory: tests/end-to-end + run: ./gradlew testClasses From 40746ef4b599f56b4bc73cee4ff5fea88f54b2ca Mon Sep 17 00:00:00 2001 From: Allain Magyar Date: Sat, 27 Apr 2024 12:41:33 -0300 Subject: [PATCH 4/5] fix: e2e build pipeline name --- .github/workflows/e2e-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-build.yml b/.github/workflows/e2e-build.yml index 6158a76e9..4e67ea5bf 100644 --- a/.github/workflows/e2e-build.yml +++ b/.github/workflows/e2e-build.yml @@ -1,4 +1,4 @@ -name: End-to-end tests +name: End-to-end build concurrency: group: ${{ github.head_ref }}${{ github.ref }}-e2e-build From c45420b862418898cad16098f4265e0f485f988b Mon Sep 17 00:00:00 2001 From: Allain Magyar Date: Mon, 29 Apr 2024 13:00:47 -0300 Subject: [PATCH 5/5] test: remove e2e build Signed-off-by: Allain Magyar --- .github/workflows/e2e-build.yml | 41 --------------------------------- 1 file changed, 41 deletions(-) delete mode 100644 .github/workflows/e2e-build.yml diff --git a/.github/workflows/e2e-build.yml b/.github/workflows/e2e-build.yml deleted file mode 100644 index 4e67ea5bf..000000000 --- a/.github/workflows/e2e-build.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: End-to-end build - -concurrency: - group: ${{ github.head_ref }}${{ github.ref }}-e2e-build - cancel-in-progress: true - -on: - pull_request: - branches: - - main - -env: - JAVA_VERSION: 17 - NODEJS_VERSION: 16.17.0 - ATALA_GITHUB_ACTOR: ${{ secrets.GITHUB_TOKEN }} - ATALA_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - -jobs: - run-e2e-tests: - name: 'Build e2e tests' - runs-on: ubuntu-latest - - steps: - - name: Install Java ${{ env.JAVA_VERSION }} - uses: actions/setup-java@v3 - with: - java-version: "${{ env.JAVA_VERSION }}" - distribution: 'adopt' - - - name: Checkout Code - uses: actions/checkout@v4 - - - name: Gradle Build Action - uses: gradle/gradle-build-action@v2 - - - name: Publish to maven local - run: ./gradlew publishToMavenLocal - - - name: Run e2e build - working-directory: tests/end-to-end - run: ./gradlew testClasses