Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: agent options non-breaking change #152

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Apr 29, 2024

Description:

This PR makes the new addition AgentOptions a non-breaking change my including a default constructor parameter to the prism agent. It also includes missing documentation for PR-150

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@cristianIOHK cristianIOHK requested a review from hamada147 April 29, 2024 14:10
Copy link

github-actions bot commented Apr 29, 2024

Unit Test Results

72 tests  ±0   68 ✅ ±0   9s ⏱️ +2s
21 suites ±0    4 💤 ±0 
21 files   ±0    0 ❌ ±0 

Results for commit 2f2bdfc. ± Comparison against base commit 0802fb7.

♻️ This comment has been updated with latest results.

@cristianIOHK cristianIOHK changed the title docs: agent options for experimental features fix: agent options for experimental features Apr 29, 2024
@cristianIOHK cristianIOHK changed the title fix: agent options for experimental features refactor: agent options for experimental features Apr 29, 2024
@cristianIOHK cristianIOHK changed the title refactor: agent options for experimental features refactor: agent options non-breaking change Apr 29, 2024
@cristianIOHK cristianIOHK merged commit 82f6c7d into main Apr 29, 2024
5 checks passed
@cristianIOHK cristianIOHK deleted the docs/live_mode_documentation branch April 29, 2024 14:40
hamada147 added a commit that referenced this pull request May 15, 2024
Co-authored-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
cristianIOHK added a commit that referenced this pull request Aug 27, 2024
Co-authored-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants