Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renames e2e test folder #156

Merged
merged 8 commits into from
Jun 11, 2024
Merged

chore: renames e2e test folder #156

merged 8 commits into from
Jun 11, 2024

Conversation

amagyar-iohk
Copy link
Contributor

@amagyar-iohk amagyar-iohk commented May 29, 2024 •
edited
Loading

Description:

Renames atala/prism references for e2e test
https://input-output.atlassian.net/browse/ATL-6471

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Unit Test Results

77 tests  ±0   75 ✅ ±0   4s ⏱️ ±0s
23 suites ±0    2 💤 ±0 
23 files   ±0    0 ❌ ±0 

Results for commit a74fcef. ± Comparison against base commit fa2eebf.

♻️ This comment has been updated with latest results.

mkbreuningIOHK
mkbreuningIOHK reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@mkbreuningIOHK mkbreuningIOHK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look to be in line with the renaming activity we started to move from IO Atala Prism to Hyperledger Identus organisation. I would leave the approval to the codeowner of Edge Agent SDK KMP though.
I have made a new commit and added a request to update the README file of the test before approval.

yshyn-iohk
yshyn-iohk reviewed May 29, 2024
View reviewed changes
tests/end-to-end/build.gradle.kts
@@ -5,7 +5,7 @@ plugins {
id("net.serenity-bdd.serenity-gradle-plugin") version "4.0.1"
}

group = "io.iohk.atala.prism"
group = "org.hyperledger.identus"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep these changes until the legal approves moving the repo under the Hyperledger org.
Otherwise, it might be difficult to release a new package: each group maintains the secrets that allow them to publish packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the automation package, there's no artifact being released from here... but should I revert this change @yshyn-iohk ?

cristianIOHK and others added 7 commits June 4, 2024 09:31
@cristianIOHK
fix: e2e test broken after pull credential changed based on validUntil
c789435
@hamada147
chore: linting
213ec4f 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
@amagyar-iohk
chore: renames e2e test folder
1a5364f 
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@mkbreuningIOHK @amagyar-iohk
Update CreateConnection.feature renaming
f7dda10 
PRISM Agent renamed to Cloud Agent
@amagyar-iohk
fix: updates e2e readme
a028b55 
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@amagyar-iohk
test: remove e2e target folder
c110b23 
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@amagyar-iohk
chore: move packages
4cde3d5 
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@amagyar-iohk
test: reverts files
a74fcef 
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
@amagyar-iohk amagyar-iohk merged commit 654da15 into main Jun 11, 2024
4 checks passed
@amagyar-iohk amagyar-iohk deleted the test/e2e-renaming branch June 11, 2024 18:37
hamada147 added a commit that referenced this pull request Jun 12, 2024
@amagyar-iohk @cristianIOHK
@hamada147 @mkbreuningIOHK
chore: renames e2e test folder (#156)
c62970d 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Co-authored-by: Cristian G <cristian.castro@iohk.io>
Co-authored-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Co-authored-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
cristianIOHK added a commit that referenced this pull request Aug 27, 2024
@amagyar-iohk @cristianIOHK
@hamada147 @mkbreuningIOHK
chore: renames e2e test folder (#156)
ee57eda 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Co-authored-by: Cristian G <cristian.castro@iohk.io>
Co-authored-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Co-authored-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkbreuningIOHK mkbreuningIOHK mkbreuningIOHK requested changes

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@hamada147 hamada147 hamada147 approved these changes

@todorkoleviohk todorkoleviohk Awaiting requested review from todorkoleviohk

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

@petevielhaber petevielhaber Awaiting requested review from petevielhaber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amagyar-iohk @hamada147 @mkbreuningIOHK @yshyn-iohk @cristianIOHK