Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increse code coverage #176

Merged
merged 5 commits into from
Jul 30, 2024
Merged

chore: increse code coverage #176

merged 5 commits into from
Jul 30, 2024

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Jul 18, 2024

Description:

Increase code coverage for edge agent.
This PR is for ticket:
https://input-output.atlassian.net/browse/ATL-7370

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Copy link

github-actions bot commented Jul 18, 2024

Unit Test Results

110 tests  +12   107 ✅ +13   7s ⏱️ -2s
 24 suites ± 0     3 💤  -  1 
 24 files   ± 0     0 ❌ ± 0 

Results for commit ff72595. ± Comparison against base commit b9571b2.

This pull request removes 2 and adds 14 tests. Note that renamed tests count towards both.
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testAnoncreds_whenOfferReceived_thenProcessed
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testPrismAgentSignWith_whenPrivateKeyAvailable_thenSignatureReturned
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent backup wallet should generate a JWE with the proper algorithm and encryption method
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent send message should call connection manager send message
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent setupMediatorDID create a new mediator handler and call setup mediator handler
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent setupMediatorHandler should stop the agent and replace the current mediatior handler
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent start should create peer did and register mediator if no mediator available
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent start should throw MediationRequestFailedError if mediatiorhandler mediator is null
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ EdgeAgent stop should change the state to stop
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testHandlePresentation_whenWrongPresentationSubmission_thenThrowMissingOrNullFieldError
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testPrepareRequestCredentialWithIssuer_whenCredentialTypeNotSupported_thenThrowException
org.hyperledger.identus.walletsdk.edgeagent.EdgeAgentTests ‑ testPrepareRequestCredentialWithIssuer_whenDIDNotPrism_thenThrowException
…

♻️ This comment has been updated with latest results.

Signed-off-by: Cristian G <cristian.castro@iohk.io>
@coveralls
Copy link

coveralls commented Jul 18, 2024

Pull Request Test Coverage Report for Build 10095865523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 42.717%

Totals Coverage Status
Change from base Build 9997356298: 1.1%
Covered Lines: 2990
Relevant Lines: 6114

💛 - Coveralls

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Cristian Gonzalez <113917899+cristianIOHK@users.noreply.github.com>
@cristianIOHK cristianIOHK merged commit 6df6a61 into main Jul 30, 2024
5 checks passed
@cristianIOHK cristianIOHK deleted the chore/increase_tests branch July 30, 2024 14:15
cristianIOHK added a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Cristian Gonzalez <113917899+cristianIOHK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants