Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error codes and remove duplicities #182

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

cristianIOHK
Copy link
Contributor

Signed-off-by: Cristian G cristian.castro@iohk.io

Description:

This PR improves the error codes. Each component has its numeric identifier Apollo 1, Castor 2, Mercury 3, Pluto 4, Pollux 5 and Agent 6. That makes it easier to identify where the error comes from.
Some of the errors were merged together as they represent the same concept.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Copy link

github-actions bot commented Aug 6, 2024

Unit Test Results

145 tests  ±0   142 ✅ ±0   7s ⏱️ ±0s
 25 suites ±0     3 💤 ±0 
 25 files   ±0     0 ❌ ±0 

Results for commit 6529c5b. ± Comparison against base commit 52c3895.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10269286420

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 43.141%

Files with Coverage Reduction New Missed Lines %
org/hyperledger/identus/walletsdk/edgeagent/EdgeAgentError.kt 16 25.0%
org/hyperledger/identus/walletsdk/edgeagent/EdgeAgent.kt 51 68.48%
Totals Coverage Status
Change from base Build 10184204750: 0.04%
Covered Lines: 3006
Relevant Lines: 6103

💛 - Coveralls

@cristianIOHK cristianIOHK merged commit 3e69b4f into main Aug 22, 2024
4 checks passed
@cristianIOHK cristianIOHK deleted the feature/ATL-5914 branch August 22, 2024 13:44
cristianIOHK added a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Cristian G <cristian.castro@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants