Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gradle artifact signing #203

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: gradle artifact signing #203

merged 2 commits into from
Sep 13, 2024

Conversation

amagyar-iohk
Copy link
Contributor

Description:

Fixes artifact signing

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Copy link

Unit Test Results

150 tests  ±0   147 ✅ ±0   7s ⏱️ ±0s
 26 suites ±0     3 💤 ±0 
 26 files   ±0     0 ❌ ±0 

Results for commit 1cb2c56. ± Comparison against base commit 59c9537.

@amagyar-iohk amagyar-iohk merged commit c5903ff into main Sep 13, 2024
6 checks passed
@amagyar-iohk amagyar-iohk deleted the fix/artifact-signing branch September 13, 2024 17:21
hyperledger-bot added a commit that referenced this pull request Sep 13, 2024
# [4.0.0](v3.0.1...v4.0.0) (2024-09-13)

### Bug Fixes

* anoncred verification and breaking changes missing ([#196](#196)) ([6b0fb55](6b0fb55))
* backup recovery was linking incorrectly dids with private keys ([#178](#178)) ([06e9a8f](06e9a8f))
* bitstring for revocation registry ([#188](#188)) ([22a2da9](22a2da9))
* DbConnection cannot be extended ([#169](#169)) ([82b03cc](82b03cc))
* e2e test broken after pull credential changed based on validUntil ([#158](#158)) ([f21df25](f21df25))
* gradle artifact signing ([#203](#203)) ([c5903ff](c5903ff))
* JWT proof ([#163](#163)) ([4e52aed](4e52aed))
* missed renaming ([c71741f](c71741f))
* renaming ([9585d1a](9585d1a))
* renaming reference issues ([3adb41f](3adb41f))
* restore process duplicates did peers ([#173](#173)) ([da747c5](da747c5))
* restore process from swift/ts jwe ([#175](#175)) ([b9571b2](b9571b2))
* Upgrade gradle ([#140](#140)) ([1e11da4](1e11da4))
* wrong casting KeyPair instead of PublicKey ([#139](#139)) ([7d0a5c9](7d0a5c9))
* zkp presentation could not be verified on the agent ([#157](#157)) ([3319dc4](3319dc4))

### Features

* Anoncreds verification ([#186](#186)) ([52c3895](52c3895))
* back up and restore ([#159](#159)) ([dcb10fd](dcb10fd))
* contactless presentation request ([#192](#192)) ([e03ebbc](e03ebbc))
* experimental opt-in for mediator live mode ([#150](#150)) ([0e30346](0e30346))
* **pollux:** add sdjwt capability ([#174](#174)) ([cd3baf8](cd3baf8))
* revocation notification event ([#148](#148)) ([e1753ec](e1753ec))
* support for mediator live mode (websocket) ([#147](#147)) ([823b8b3](823b8b3))
* verification from SDK ([#155](#155)) ([61720b8](61720b8))
* Verification JWT Revocation registry check ([#165](#165)) ([755a7ef](755a7ef))

### BREAKING CHANGES

* Pollux Module
- `restoreCredential` now requires a third parameter `revoked`.
- Removed: `createVerifiablePresentationJWT`, `createVerifiablePresentationAnoncred`, `getCredentialDefinition`, and `getSchema`.
- Added new method: `processCredentialRequestSDJWT`.
- `PolluxImpl` now implements `processCredentialRequestSDJWT`.
- Pollux methods `parseCredential` and `processCredentialRequestAnoncreds` now accept `linkSecret: String` instead of `linkSecret: LinkSecret`.

ConnectionManager
- `ConnectionManager` is now an interface, and `ConnectionManagerImpl` is the new implementation.
- `ConnectionManager` construct now requires a Pollux instance.

Edge Agent (formerly PrismAgent)
- The constructor now requires a new parameter: `AgentOptions`.
- `PrismAgent` renamed to `EdgeAgent`.
- `preparePresentationForRequestProof` now expects a `Credential` of type T, where T can be `Credential` or `ProvableCredential`.

JWT Verifiable Credential
- The `JWTVerifiableCredential` constructor replaces the parameter `credentialStatus: VerifiableCredentialTypeContainer` with `credentialStatus: CredentialStatus`.

Pluto Module
- `getDIDPrivateKeysByDID` and `getDIDPrivateKeyByID` now return `Flow<List<StorablePrivateKey?>>`.
- New method added: `getAllPrivateKeys`.
- `PlutoImpl` deprecated `storeCredentialMetadata(name: String, metadata: CredentialRequestMeta)` and replaced it with `storeCredentialMetadata(name: String, linkSecretName: String, json: String)`.

Apollo Module
- `restorePrivateKey(storablePrivateKey: StorablePrivateKey): PrivateKey` changed to `restorePrivateKey(restorationIdentifier: String, privateKeyData: String): PrivateKey`.

DbConnection
- `DbConnection` is now an interface.
- `DbConnectionImpl` is the new instance used for DB connections.

Presentation Submissions
- `createPresentationSubmission` parameter `presentationDefinitionRequest: PresentationDefinitionRequest` changed to `presentationDefinitionRequestString: String`, and the return type changed to `String`.
- New methods added: `createJWTPresentationSubmission`, `createAnoncredsPresentationSubmission`, and `getSchema`.
- `createPresentationDefinitionRequest` now returns a `String`.

OutOfBandInvitation
- New constructor parameters: `attachments`, `createdTime`, and `expiresTime`.

Module Renaming
- `AtalaPrismSDK` renamed to `EdgeAgentSDK`.
- Package name changed from `io.iohk.atala.prism.walletsdk` to `org.hyperledger.identus.walletsdk`.
- `publishedMavenId` changed from `io.iohk.atala.prism.walletsdk` to `org.hyperledger.identus`.
- Namespace changed from `org.hyperledger.identus.walletsdk` to `org.hyperledger.identus`.

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
# [4.0.0](v3.0.1...v4.0.0) (2024-09-13)

### Bug Fixes

* anoncred verification and breaking changes missing ([#196](#196)) ([6b0fb55](6b0fb55))
* backup recovery was linking incorrectly dids with private keys ([#178](#178)) ([06e9a8f](06e9a8f))
* bitstring for revocation registry ([#188](#188)) ([22a2da9](22a2da9))
* DbConnection cannot be extended ([#169](#169)) ([82b03cc](82b03cc))
* e2e test broken after pull credential changed based on validUntil ([#158](#158)) ([f21df25](f21df25))
* gradle artifact signing ([#203](#203)) ([c5903ff](c5903ff))
* JWT proof ([#163](#163)) ([4e52aed](4e52aed))
* missed renaming ([c71741f](c71741f))
* renaming ([9585d1a](9585d1a))
* renaming reference issues ([3adb41f](3adb41f))
* restore process duplicates did peers ([#173](#173)) ([da747c5](da747c5))
* restore process from swift/ts jwe ([#175](#175)) ([b9571b2](b9571b2))
* Upgrade gradle ([#140](#140)) ([1e11da4](1e11da4))
* wrong casting KeyPair instead of PublicKey ([#139](#139)) ([7d0a5c9](7d0a5c9))
* zkp presentation could not be verified on the agent ([#157](#157)) ([3319dc4](3319dc4))

### Features

* Anoncreds verification ([#186](#186)) ([52c3895](52c3895))
* back up and restore ([#159](#159)) ([dcb10fd](dcb10fd))
* contactless presentation request ([#192](#192)) ([e03ebbc](e03ebbc))
* experimental opt-in for mediator live mode ([#150](#150)) ([0e30346](0e30346))
* **pollux:** add sdjwt capability ([#174](#174)) ([cd3baf8](cd3baf8))
* revocation notification event ([#148](#148)) ([e1753ec](e1753ec))
* support for mediator live mode (websocket) ([#147](#147)) ([823b8b3](823b8b3))
* verification from SDK ([#155](#155)) ([61720b8](61720b8))
* Verification JWT Revocation registry check ([#165](#165)) ([755a7ef](755a7ef))

### BREAKING CHANGES

* Pollux Module
- `restoreCredential` now requires a third parameter `revoked`.
- Removed: `createVerifiablePresentationJWT`, `createVerifiablePresentationAnoncred`, `getCredentialDefinition`, and `getSchema`.
- Added new method: `processCredentialRequestSDJWT`.
- `PolluxImpl` now implements `processCredentialRequestSDJWT`.
- Pollux methods `parseCredential` and `processCredentialRequestAnoncreds` now accept `linkSecret: String` instead of `linkSecret: LinkSecret`.

ConnectionManager
- `ConnectionManager` is now an interface, and `ConnectionManagerImpl` is the new implementation.
- `ConnectionManager` construct now requires a Pollux instance.

Edge Agent (formerly PrismAgent)
- The constructor now requires a new parameter: `AgentOptions`.
- `PrismAgent` renamed to `EdgeAgent`.
- `preparePresentationForRequestProof` now expects a `Credential` of type T, where T can be `Credential` or `ProvableCredential`.

JWT Verifiable Credential
- The `JWTVerifiableCredential` constructor replaces the parameter `credentialStatus: VerifiableCredentialTypeContainer` with `credentialStatus: CredentialStatus`.

Pluto Module
- `getDIDPrivateKeysByDID` and `getDIDPrivateKeyByID` now return `Flow<List<StorablePrivateKey?>>`.
- New method added: `getAllPrivateKeys`.
- `PlutoImpl` deprecated `storeCredentialMetadata(name: String, metadata: CredentialRequestMeta)` and replaced it with `storeCredentialMetadata(name: String, linkSecretName: String, json: String)`.

Apollo Module
- `restorePrivateKey(storablePrivateKey: StorablePrivateKey): PrivateKey` changed to `restorePrivateKey(restorationIdentifier: String, privateKeyData: String): PrivateKey`.

DbConnection
- `DbConnection` is now an interface.
- `DbConnectionImpl` is the new instance used for DB connections.

Presentation Submissions
- `createPresentationSubmission` parameter `presentationDefinitionRequest: PresentationDefinitionRequest` changed to `presentationDefinitionRequestString: String`, and the return type changed to `String`.
- New methods added: `createJWTPresentationSubmission`, `createAnoncredsPresentationSubmission`, and `getSchema`.
- `createPresentationDefinitionRequest` now returns a `String`.

OutOfBandInvitation
- New constructor parameters: `attachments`, `createdTime`, and `expiresTime`.

Module Renaming
- `AtalaPrismSDK` renamed to `EdgeAgentSDK`.
- Package name changed from `io.iohk.atala.prism.walletsdk` to `org.hyperledger.identus.walletsdk`.
- `publishedMavenId` changed from `io.iohk.atala.prism.walletsdk` to `org.hyperledger.identus`.
- Namespace changed from `org.hyperledger.identus.walletsdk` to `org.hyperledger.identus`.

Signed-off-by: Cristian G <cristian.castro@iohk.io>
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants