Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and clean-up of duplicate code #110

Open
WadeBarnes opened this issue Jan 4, 2022 · 0 comments
Open

Refactoring and clean-up of duplicate code #110

WadeBarnes opened this issue Jan 4, 2022 · 0 comments

Comments

@WadeBarnes
Copy link
Member

The circular dependances described in #102 have been addressed by #109.

The PR addressed the issues by creating a new ./system_node_only folder which does not contain any of the Sovrin dependencies. In the process much of the code was duplicated. In the interest of time this was deemed acceptable. This ticket is the placeholder for the refactoring and cleanup activities that would need to follow to address the duplicate code.

The similarities and differences between the ./system and ./system_node_only tests are described here; https://github.com/hyperledger/indy-test-automation/tree/main/system_node_only#similarities-between-system-and-system_node_only

Some thoughts on the direction the refactoring and cleanup could go can be found in the Next Steps (as I see them) section of this comment; #102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant