Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create dockerfile #36

Merged
merged 3 commits into from
Jan 3, 2024
Merged

create dockerfile #36

merged 3 commits into from
Jan 3, 2024

Conversation

kevinmingtarja
Copy link
Member

@kevinmingtarja kevinmingtarja commented Dec 19, 2023 •
edited
Loading

  • Create Dockerfile for building docker images
    • multi-stage builds to create the binary inside a container instead of building it in host machine and copying it to the container
  • Update README with docker build and run steps
  • Expose --dgraph flag to make the dgraph url to connect to configurable

@mattjohnsonpint mattjohnsonpint merged commit 004d9ab into main Jan 3, 2024
2 checks passed
@mattjohnsonpint mattjohnsonpint deleted the kevin/dockerfile branch January 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint left review comments

@all-seeing-code all-seeing-code Awaiting requested review from all-seeing-code

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinmingtarja @mattjohnsonpint @all-seeing-code