Fix potential array out of bounds in the runtime #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattjohnsonpint
changed the title
|
Note, this is unlikely, and not really a security issue. But fixed nonetheless. |
jairad26
previously approved these changes
Oct 8, 2024
jairad26
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/hypermodeinc/modus/security/code-scanning/2
To fix the problem, we need to ensure that the value returned by
strconv.Atoiis within the bounds ofuint32before performing the conversion. This can be done by checking if the parsed integer is within the range of0tomath.MaxUint32. If the value is out of bounds, we should return an error.ArrayLengthfunction to include bounds checking for the parsed integer.strconv.ParseUintwith a bit size of 32 to directly parse the string into auint32if possible.