Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change environment variable name and default #439

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Change environment variable name and default #439

merged 5 commits into from
Oct 8, 2024

Conversation

mattjohnsonpint
Copy link
Collaborator

Description

  • Changed the environment variable name from ENVIRONMENT to MODUS_ENV, to avoid conflicts with other software.
  • Changed the default environment from "dev" to "prod".
  • Added notes explaining the rationale for the change.
  • Added tests
  • Add the environment name to the starting log message
  • Updated the changelog

Checklist

  • Code compiles correctly and linting passes locally
  • Tests for new functionality and regression tests for bug fixes added
  • Documentation added or updated
  • Entry added to the CHANGELOG.md file describing and linking to this PR

Thank you for your contribution to the Modus project!

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner October 8, 2024 16:47
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) October 8, 2024 17:34
@mattjohnsonpint mattjohnsonpint merged commit bf24f62 into main Oct 8, 2024
75 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2322-change-environment-variable-name-and-default branch October 8, 2024 17:36
@mattjohnsonpint mattjohnsonpint added this to the v0.13.0 milestone Oct 8, 2024
@mattjohnsonpint mattjohnsonpint mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairad26 jairad26 jairad26 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjohnsonpint @jairad26