Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Go Modules #450

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Cleanup Go Modules #450

merged 11 commits into from
Oct 10, 2024

Conversation

mattjohnsonpint
Copy link
Collaborator

@mattjohnsonpint mattjohnsonpint commented Oct 10, 2024 •
edited
Loading

Description

  • Move shared Go libraries from package root to separate modules in /lib
  • Combine go.mod for the Go SDK and the build tool within the Go SDK
  • Remove replace directives for the Go SDK so the build tool can be installed with go install (by the CLI)
  • Update path usage throughout
  • Update Go SDK workflow

Checklist

  • Code compiles correctly and linting passes locally
  • Tests for new functionality and regression tests for bug fixes added
  • Documentation added or updated
  • Entry added to the CHANGELOG.md file describing and linking to this PR

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner October 10, 2024 22:11
@mattjohnsonpint mattjohnsonpint merged commit 4c562de into main Oct 10, 2024
80 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2387-cleanup-go-modules branch October 10, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairad26 jairad26 jairad26 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjohnsonpint @jairad26