ALTAPPS-1346: Shared, iOS code blanks elif else statements #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…40/Shared-iOS-Code-blanks-conditions
… into feature/ALTAPPS-1346/Shared-iOS-Code-blanks-elif-else-blocks
… into feature/ALTAPPS-1346/Shared-iOS-Code-blanks-elif-else-blocks
… into feature/ALTAPPS-1346/Shared-iOS-Code-blanks-elif-else-blocks
…ode-blanks-conditions
…ode-blanks-conditions
ivan-magda
changed the title
XanderZhu
approved these changes
Sep 11, 2024
Comment on lines
+40
to
+42
| internal val codeBlanksVariablesAndStringsSuggestions: List<Suggestion.ConstantString> = | ||
| codeBlanksVariablesSuggestions + codeBlanksStringsSuggestions | ||
|
|
There was a problem hiding this comment.
Can we extract all these fields into extensions?
It is a common practice in kotlin to not store logic in the data class.
There was a problem hiding this comment.
An extension property cannot have stored properties. If we move this to an extension, it will be recomputed each time.
XanderZhu
added
ready to pull
Base automatically changed from
feature/ALTAPPS-1340/Shared-iOS-Code-blanks-conditions
to
develop
September 12, 2024 06:31
ivan-magda
deleted the
feature/ALTAPPS-1346/Shared-iOS-Code-blanks-elif-else-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-1346
Checklist
Before Code Review:
Description
elifandelsestatements support