Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1082, ALTAPPS-1083: Update Gradle & AGP #801

Merged
merged 13 commits into from
Dec 21, 2023
Merged

ALTAPPS-1082, ALTAPPS-1083: Update Gradle & AGP #801

merged 13 commits into from
Dec 21, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Dec 19, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
ALTAPPS-1082, ALTAPPS-1083

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • MokoResourse 0.23.0
  • Update colors retrieving in CollorPallet
  • Gradle 7.5
  • AGP 7.4.2

@XanderZhu XanderZhu added shared Shared module task ios iOS module task labels Dec 19, 2023
@XanderZhu XanderZhu added this to the 1.46 milestone Dec 19, 2023
@XanderZhu XanderZhu self-assigned this Dec 19, 2023
@github-actions github-actions bot added the android Android module task label Dec 19, 2023
@XanderZhu
Copy link
Contributor Author

XanderZhu commented Dec 19, 2023 •
edited
Loading

@ivan-magda
I upgraded Moko resources because it was required to update the Gradle version

@XanderZhu XanderZhu marked this pull request as ready for review December 20, 2023 09:04
@XanderZhu XanderZhu requested a review from ivan-magda December 20, 2023 09:04
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Dec 20, 2023
@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Dec 20, 2023
@XanderZhu XanderZhu removed the awaiting changes Changes requested, waiting on author to update label Dec 20, 2023
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Dec 20, 2023
@XanderZhu XanderZhu requested a review from ivan-magda December 20, 2023 18:18
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Dec 21, 2023
@ivan-magda ivan-magda merged commit a71e7ec into develop Dec 21, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1082/update-agp branch December 21, 2023 02:54
@ivan-magda ivan-magda changed the title Update Gradle & AGP ALTAPPS-1082, ALTAPPS-1083: Update Gradle & AGP Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda