Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared: Disable Sentry debug logs #808

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Shared: Disable Sentry debug logs #808

merged 2 commits into from
Dec 21, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Dec 20, 2023 •
edited
Loading

YouTrack Issues:

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Disable sentry debug logs to not have sentry internal logs.

@XanderZhu XanderZhu added the shared Shared module task label Dec 20, 2023
@XanderZhu XanderZhu added this to the 1.46 milestone Dec 20, 2023
@XanderZhu XanderZhu self-assigned this Dec 20, 2023
@XanderZhu XanderZhu requested a review from ivan-magda December 20, 2023 18:08
@github-actions github-actions bot added the android Android module task label Dec 20, 2023
@XanderZhu XanderZhu marked this pull request as ready for review December 20, 2023 18:08
ivan-magda
ivan-magda reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What purpose of this PR? I don't understand why you are making this changes.

@XanderZhu
Copy link
Contributor Author

@ivan-magda
All the feature logs have severity INFO, so I changed the min severity for the feature logger.
Also, Sentry currently has min severity DEBUG and writes all its internal debug logs, including network logs. Another reason to disable debug logs for sentry is that SentryLogWriter doesn't support sending this kind of logs.

@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Dec 21, 2023
@ivan-magda ivan-magda changed the title Shared disable sentry debug logs Shared: disable sentry debug logs Dec 21, 2023
@ivan-magda ivan-magda changed the title Shared: disable sentry debug logs Shared: Disable sentry debug logs Dec 21, 2023
@ivan-magda ivan-magda changed the title Shared: Disable sentry debug logs Shared: Disable Sentry debug logs Dec 21, 2023
@github-actions github-actions bot added the ios iOS module task label Dec 21, 2023
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Dec 21, 2023
@XanderZhu XanderZhu merged commit 359f30a into develop Dec 21, 2023
9 checks passed
@XanderZhu XanderZhu deleted the feature/Clean_log branch December 21, 2023 15:30
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Dec 22, 2023
@ivan-magda ivan-magda mentioned this pull request Dec 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda