Fix version editable install and add releasing guide #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 46.97% 47.34% +0.36%
==========================================
Files 10 10
Lines 447 452 +5
Branches 71 72 +1
==========================================
+ Hits 210 214 +4
Misses 230 230
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
ericpre
force-pushed
the
fix_version_editable_install
branch
from
42e2846
to
eb419a6
Compare
jlaehne
approved these changes
May 5, 2024
jlaehne
reviewed
May 5, 2024
Comment on lines
+7
to
+10
| def run_towncrier(tag): | ||
| cmd = ("towncrier", "build", "--version", tag.strip("v")) | ||
|
|
||
| return subprocess.call(cmd) |
There was a problem hiding this comment.
dos not seem to be using towncrier so far
There was a problem hiding this comment.
I opted for leaving the script as it is but commented out the call to this function in the __main__ block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.