-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slider in image contrast editor on python >=3.10 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 47.34% 44.83% -2.51%
==========================================
Files 10 12 +2
Lines 452 707 +255
Branches 72 104 +32
==========================================
+ Hits 214 317 +103
- Misses 230 378 +148
- Partials 8 12 +4 ☔ View full report in Codecov by Sentry. |
10 tasks
ericpre
force-pushed
the
fix_rangeslider_issue
branch
from
May 6, 2024 20:19
1ced43c
to
bbce235
Compare
… 2.1 is released
ericpre
force-pushed
the
fix_rangeslider_issue
branch
from
May 7, 2024 08:24
bbce235
to
96fae29
Compare
Merging this PR to release, to prepare to be able to release soon after hyperspy 2.1 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On python 3.10, the slider of the image contrast editor are broken:
Press on
h
key to open the image contrast editor and the percentile slider are missing.The error is:
xref enthought/traitsui#2048 for a fix in
traitsui
.Needs hyperspy/hyperspy#3368