Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented navigation logic and dependency exchange for proposal creation steps #353

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nbetsaif
Copy link
Collaborator

@nbetsaif nbetsaif commented Oct 18, 2024

This PR integrates the logic of proposal creation with the UI across all steps by centralizing state management using ProposalCreationBloc. Each screen now consumes data from previous steps, allowing for seamless navigation and dynamic UI updates. User selections, such as the outcome type, are passed forward. Bloc events efficiently handle interactions, ensuring data persistence and maintaining a single source of truth. Refactoring components like HyphaOutcomeCard for direct bloc interaction enhances code reusability and maintainability

Screenshots

Before After
Before After

@nbetsaif nbetsaif requested a review from n13 October 18, 2024 14:28
@nbetsaif nbetsaif self-assigned this Oct 18, 2024
@nbetsaif nbetsaif changed the title feat: Implemented navigation logic and dependency exchange for propos… feat: Implemented navigation logic and dependency exchange for proposal creation screens Oct 18, 2024
@nbetsaif nbetsaif changed the title feat: Implemented navigation logic and dependency exchange for proposal creation screens feat: Implemented navigation logic and dependency exchange for proposal creation steps Oct 18, 2024
@Zied-Dahmani Zied-Dahmani self-assigned this Oct 18, 2024
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbetsaif nbetsaif merged commit 68fe5b6 into main Oct 22, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants