refactor: remove proposal type selection page #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Oct 25, 2024
| @@ -157,8 +150,8 @@ class ProposalCreationPage extends StatelessWidget { | |||
| children: [ | |||
| const DaoSelectionView(), | |||
| const ProposalContentView(), | |||
| const OutcomeSelectionView(), | |||
| Container(), | |||
| //const OutcomeSelectionView(), | |||
There was a problem hiding this comment.
commented code - please remove?
n13
approved these changes
Oct 25, 2024
You're absolutely right, and I completely acknowledge this policy. I left the code commented to easily retrieve it later, but I’ll go ahead and remove it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Ticket
I've removed the proposal type selection page when creating a proposal, as the type is now set to
Agreementby default.