refactor: proposal details #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Nov 8, 2024
| @@ -8,72 +7,13 @@ import 'package:json_annotation/json_annotation.dart'; | |||
|
|
|||
| part 'proposal_details_model.g.dart'; | |||
|
|
|||
| enum TokenType { | |||
| utility, | |||
| voice, | |||
There was a problem hiding this comment.
why was nearly all code removed from this class? We don't need any of this??
There was a problem hiding this comment.
Yeah, for now, according to the Figma UI update from @luigicarlini1988 (@arsenijesavic) , we don’t need to use these fields. If we find a need for them later, I can look into a new or better approach otherwise I can always revert these changes.
n13
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Ticket
This PR refactors the
Proposal Detailsview to partially align with the latest Figma design updates. Key changes include:DurationandRewardssections.