feat(Heading): create heading component #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
plitzenberger
requested changes
Nov 11, 2024
apps/web/src/app/[lang]/page.tsx
Outdated
| /> | ||
| </Link> | ||
| <div className="px-6 py-4"> | ||
| <Heading className="mb-4" size={9} color="#fff" weight="medium" align="center">All your spaces, in one place</Heading> |
There was a problem hiding this comment.
There are some type errors for color and weight. See my comment on the component also
| { | ||
| variants: { | ||
| size: { | ||
| 1: 'text-[14px] leading-tight', // h9 |
There was a problem hiding this comment.
We should probably define those at the tailwind.config.js to keep all configuration in one location
| export interface HeadingProps | ||
| extends React.HTMLAttributes<HTMLHeadingElement>, | ||
| VariantProps<typeof headingVariants> { | ||
| asChild?: boolean; |
There was a problem hiding this comment.
I was able to fix the color type error by overwriting it here:
Suggested change
| asChild?: boolean; | |
| asChild?: boolean; | |
| color?: 'primary' | 'secondary'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist