security-context: close client fds after disconnect

hyprwm · Oct 6, 2024 · 4e41cda · 4e41cda
1 parent da86aac
commit 4e41cda
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/protocols/SecurityContext.cpp b/src/protocols/SecurityContext.cpp
@@ -14,8 +14,8 @@ static int onCloseFdEvent(int fd, uint32_t mask, void* data) {
     return 0;
 }
 
-SP<CSecurityContextSandboxedClient> CSecurityContextSandboxedClient::create(int clientFD) {
-    auto p = SP<CSecurityContextSandboxedClient>(new CSecurityContextSandboxedClient(clientFD));
+SP<CSecurityContextSandboxedClient> CSecurityContextSandboxedClient::create(int clientFD_) {
+    auto p = SP<CSecurityContextSandboxedClient>(new CSecurityContextSandboxedClient(clientFD_));
     if (!p->client)
         return nullptr;
     return p;
@@ -26,7 +26,7 @@ static void onSecurityContextClientDestroy(wl_listener* l, void* d) {
     client->onDestroy();
 }
 
-CSecurityContextSandboxedClient::CSecurityContextSandboxedClient(int clientFD) {
+CSecurityContextSandboxedClient::CSecurityContextSandboxedClient(int clientFD_) : clientFD(clientFD_) {
     client = wl_client_create(g_pCompositor->m_sWLDisplay, clientFD);
     if (!client)
         return;
@@ -37,6 +37,7 @@ CSecurityContextSandboxedClient::CSecurityContextSandboxedClient(int clientFD) {
 
 CSecurityContextSandboxedClient::~CSecurityContextSandboxedClient() {
     wl_list_remove(&destroyListener.link);
+    close(clientFD);
 }
 
 void CSecurityContextSandboxedClient::onDestroy() {

diff --git a/src/protocols/SecurityContext.hpp b/src/protocols/SecurityContext.hpp
@@ -47,9 +47,10 @@ class CSecurityContextSandboxedClient {
     wl_listener destroyListener;
 
   private:
-    CSecurityContextSandboxedClient(int clientFD);
+    CSecurityContextSandboxedClient(int clientFD_);
 
-    wl_client* client = nullptr;
+    wl_client* client   = nullptr;
+    int        clientFD = -1;
 
     friend class CSecurityContextProtocol;
     friend class CSecurityContext;