subprojects: remove wlroots.wrap #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. With d179501 there's no need for |
|
Thanks for the input, merging then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
From @jbeich's testing, the wrap file doesn't work as it should, and having it
is not consistent with the other subprojects. See
hyprwm/hyprland-wiki#200 (comment) for
more info.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
The wiki command
meson subprojects update --resetwon't work anymore (if iteven worked in the first place). It will be removed in the PR linked above.
Is it ready for merging, or does it need work?
Might be ready. @jbeich thoughts?