layout: add drag_into_group #8004
Merged
+63
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Oct 7, 2024
Aqa-Ib
force-pushed
the
drag_into_group
branch
6 times, most recently
from
f6a2b0d
to
dbca84d
Compare
… a unlocked group will merge them
Aqa-Ib
force-pushed
the
drag_into_group
branch
from
dbca84d
to
dbe1852
Compare
|
OK, I have refactored the code. Now it is clean. |
vaxerski
pushed a commit
to hyprwm/hyprland-wiki
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This adds the config option drag_into_group to control whether dragging a window into a unlocked group will merge them. Options: 0 (disabled), 1 (enabled), 2 (only when dragging into the groupbar). Wiki
Also does (compared to main):
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I have tested every scenario I could imagine and everything is working fine.
Is it ready for merging, or does it need work?
It is ready.