Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake.nix: add xdph follows #8012

Conversation

timon-schelling
Copy link
Contributor

Describe your PR, what does it fix/add?

Fixes a duplicate hyprland-protocols instance in flake.lock due to xdph not following hyprlands instance.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

The removal of the second hyprland-protocols instance hyprland-protocols_2 in flake.lock could also be done in the next flake update.

Is it ready for merging, or does it need work?

I'm currently using this in my own NixOS configuration, and from what I can see, everything is functioning as expected. Ready for merging :)

fixes a duplicate  hyprland-protocols instance sometimes being created due to xdph not following hyprlands instance
@leiserfg
Copy link
Contributor

leiserfg commented Oct 7, 2024

IMHO it's better to update the flake right away. You can do nix flake lock --update-input hyprland-protocols if you don't wanna touch the other inputs.

@timon-schelling
Copy link
Contributor Author

@leiserfg I did, see flake.lock

@fufexan fufexan merged commit 5bf7b1e into hyprwm:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants