-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CTM (color transformation matrix) #89
Comments
hm, the problem is that wl-sunset et al that control this on hyprland via the wlr gamma protocol can only provide a ramp, not a matrix. How would we control the amount of red-shifting? |
I don't know exactly how KDE did it, but they have CTM support merged: https://invent.kde.org/plasma/kwin/-/merge_requests/3296 |
they dont have to support stuff like wl-sunset though (and they dont) while we do |
They seem to have updated some gamma control code too though. So it looks like they use the CTM through gammaControl if I interpreted the C++ code right (I like programming, but not in C++). |
no, they didnt |
So CTM control is ready for a new wlr protocol? |
wlr makes no sense (we arent wlr anymore) I'd either:
|
looking at drm support it seems that all drivers support CTMs. Well, all that matter. AMD, Nvidia, Intel. |
I'll try to draft a protocol later today if I don't forget at hyprland-protocols. Ping me tomorrow if I don't |
closing this as aquamarine is done. Hyprland see hyprwm/Hyprland#8023, client see https://github.com/hyprwm/hyprsunset. If you compile from 8023 you should be able to use hyprsunset no problem, tested on my machine, but lmk if it works on apple. cheers |
I am currently working on Asahi Linux with Hyprland. Everything works perfectly, except for night light. After some research I found AsahiLinux/docs#67.
The mentioned gammastep issue had a comment pointing to an issue in wlroots. As Hyprland is independent now (and uses aquamarine which does the gamma LUT stuff), I thought it'd be a great idea to implement the CTM here too.
The text was updated successfully, but these errors were encountered: