Installation: improve FreeBSD instructions for Manual Build #200

jbeich · 2023-04-25T15:05:18Z

No description provided.

vaxerski · 2023-04-25T16:06:27Z

huh why is cmake linux only?

jbeich · 2023-05-01T21:22:11Z

huh why is cmake linux only?

I've dropped 2ec125b in favor of hyprwm/Hyprland#2209

fufexan · 2023-08-11T17:23:55Z

@jbeich has anything changed since 4 months ago?

jbeich · 2023-08-11T21:16:14Z

Not much:

Both CMake and Meson (from this PR) instructions still work
FreeBSD 13.3/14.0 haven't been released yet, so building with GCC is still easier

105b552 added meson subprojects update --reset but it's broken outside of Nix:

$ git clone https://github.com/hyprwm/Hyprland
$ cd Hyprland
$ meson subprojects update --reset
Updating udis86...
  -> Cannot update subproject with no wrap file
Updating tracy...
  -> Cannot update subproject with no wrap file
Updating hyprland-protocols...
  -> Cannot update subproject with no wrap file
Initialized empty Git repository in /tmp/Hyprland/subprojects/wlroots/.git/
remote: Enumerating objects: 480, done.
remote: Counting objects: 100% (480/480), done.
remote: Compressing objects: 100% (466/466), done.
remote: Total 480 (delta 27), reused 160 (delta 5), pack-reused 0
Receiving objects: 100% (480/480), 773.01 KiB | 300.00 KiB/s, done.
Resolving deltas: 100% (27/27), done.
From https://gitlab.freedesktop.org/wlroots/wlroots
 * branch            c74f89d4f84bfed0284d3908aee5d207698c70c5 -> FETCH_HEAD
HEAD is now at c74f89d Avoid using memcpy() to copy structs
Applying diff file "wlroots-meson-build.patch"
Updating wlroots...
  -> c74f89d (grafted, HEAD) Avoid using memcpy() to copy structs [Simon Ser]

$ meson setup build
$ meson compile -C build
[...]
../subprojects/wlroots/include/wlr/render/egl.h:19:10: fatal error: 'wlr/config.h' file not found
#include <wlr/config.h>
         ^~~~~~~~~~~~~~

$ find . -name config.h
./build/subprojects/wlroots/include/wlroots/config.h
./build/subprojects/wlroots/include/config.h
$ find . -name wlr
./subprojects/wlroots/include/wlr
./subprojects/wlroots/include/wlr/wlr
$ readlink ./subprojects/wlroots/include/wlr/wlr
/tmp/Hyprland/subprojects/wlroots/include/wlr

$ cat subprojects/packagefiles/wlroots-meson-build.patch
[...]
-install_subdir('wlr',
+install_subdir('wlroots',
[...]

fufexan · 2023-08-12T11:35:59Z

but it's broken outside of Nix

Can I fix it somehow or is it better to just not use meson subprojects?

jbeich · 2023-11-10T13:15:31Z

Better remove wlroots.wrap. It's not consistent with other subprojects (e.g., hyprland-protocols, udis86) or CMake support.

Downstream I use git submodule instead of meson subprojects and system wlroots (a la Nix), so don't need synthetic soversion bump.

fufexan · 2023-11-10T21:45:24Z

Alright, I'll remove it soon (unless I forget).

fufexan · 2024-01-31T12:05:14Z

Is there anything left to do in this PR or is it ready? @jbeich

jbeich · 2024-01-31T12:24:05Z

Tested both Meson and CMake instructions - still good.

jbeich · 2024-01-31T12:25:59Z

Wait, --skip-subprojects may be wrong for the plugin API.

fufexan · 2024-01-31T13:43:36Z

Is there anything that can be done on the meson side, so we don't have to include all the commands here? The wlroots.wrap file used to patch the subproject so it properly installed headers, but now I don't know of a better approach.

- ninja doesn't support `--tags` unlike meson - `--skip-subprojects` is more clear than `--tags runtime,man`

Trying to build in a random directory like HOME may fail or build something else. So, provide the context for a user who skipped reading CMake section.

freebsd/freebsd-ports@1b744b687e87

hyprwm/Hyprland@d36055054651 freebsd/freebsd-ports@57bb94121dc2

Until GCC_DEFAULT is bumped to 14 or later in https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.default-versions.mk

System tomlplusplus is built against libc++ which conflicts with libstdc++ used by GCC. While tomlplusplus can be bundled it's only easy to do via Meson (--force-fallback-for). /usr/local/bin/ld: hyprpm/CMakeFiles/hyprpm.dir/src/core/DataState.cpp.o: in function `DataState::addNewPluginRepo(SPluginRepository const&)': DataState.cpp:(.text+0x16b4): undefined reference to `toml::v3::table::get_lower_bound(std::basic_string_view<char, std::char_traits<char> >)' /usr/local/bin/ld: DataState.cpp:(.text+0x1793): undefined reference to `toml::v3::table::insert_with_hint(toml::v3::impl::table_iterator<true>, toml::v3::key&&, std::unique_ptr<toml::v3::node, std::default_delete<toml::v3::node> >&&)' /usr/local/bin/ld: DataState.cpp:(.text+0x2c59): undefined reference to `toml::v3::impl::print_to_stream(std::ostream&, toml::v3::table const&)' /usr/local/bin/ld: hyprpm/CMakeFiles/hyprpm.dir/src/core/DataState.cpp.o: in function `DataState::pluginRepoExists(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': DataState.cpp:(.text+0x3739): undefined reference to `toml::v3::ex::parse_file(std::basic_string_view<char, std::char_traits<char> >)' /usr/local/bin/ld: DataState.cpp:(.text+0x3783): undefined reference to `toml::v3::table::get(std::basic_string_view<char, std::char_traits<char> >)' /usr/local/bin/ld: DataState.cpp:(.text+0x37ab): undefined reference to `toml::v3::table::get(std::basic_string_view<char, std::char_traits<char> >)' [...]

hyprwm/Hyprland@13f6f0b923ff hyprwm/Hyprland@c3882bb83240 hyprwm/Hyprland@ea954494024c hyprwm/Hyprland@8c64a4bad710

hyprwm/Hyprland@016da234d0e8

FreeBSD uuid(3) has slightly different API than Linux and doesn't support random UUIDs unlike NetBSD. Instead use external implementation. hyprwm/Hyprland@7778f01194d8

hyprwm/Hyprland@c03dc47124ca

jbeich · 2024-09-21T15:11:27Z

I've dropped Meson workaround and rebased after aquamarine switch.

fufexan · 2024-09-22T09:45:30Z

pages/Getting Started/Installation.md

-ninja -C build
-ninja -C build install --tags runtime,man
+meson compile -C build
+meson install -C build --skip-subprojects


Does this not mean udis86 will not be found?

udis86 is not part of Hyprland plugin API unlike wlroots was before aquamarine. --skip-subprojects is still necessary to avoid installing hyprland-protocols (plugins use preprocessed headers instead). Hyprland itself doesn't support building against system-wide copy of udis86 (Alpine patches this), and the bundled version uses CMake to build the submodule.

That's fine by me. However, I've made progress towards allowing Hyprland to build with a system-wide copy of udis86 (provided it's canihavesomecoffee's fork, which includes a .pc file). See this PR for more info about it, maybe leave your thoughts as well hyprwm/Hyprland#7885.

jbeich force-pushed the freebsd-install branch from 1197957 to d1a5846 Compare April 25, 2023 15:12

jbeich force-pushed the freebsd-install branch from d1a5846 to 2b40a3b Compare May 1, 2023 21:26

fufexan approved these changes Aug 11, 2023

View reviewed changes

jbeich force-pushed the freebsd-install branch from 2b40a3b to 77dfa60 Compare August 11, 2023 21:14

jbeich force-pushed the freebsd-install branch 2 times, most recently from 5ca64b1 to d3a0024 Compare January 5, 2024 17:10

fufexan mentioned this pull request Jan 31, 2024

subprojects: remove wlroots.wrap hyprwm/Hyprland#4572

Merged

fufexan mentioned this pull request Feb 1, 2024

hyprpm: install headers locally hyprwm/Hyprland#4585

Merged

jbeich added 11 commits September 21, 2024 16:02

Installation: unbreak Meson steps

7838792

- ninja doesn't support `--tags` unlike meson - `--skip-subprojects` is more clear than `--tags runtime,man`

Installation: invoke Git when using Meson like with CMake

2687184

Trying to build in a random directory like HOME may fail or build something else. So, provide the context for a user who skipped reading CMake section.

Installation: deduplicate FreeBSD dependencies

55b2498

freebsd/freebsd-ports@1b744b687e87

Installation: add tomlplusplus on FreeBSD

13395a2

hyprwm/Hyprland@d36055054651 freebsd/freebsd-ports@57bb94121dc2

Installation: temporarily pin GCC version on FreeBSD

4b257f5

Until GCC_DEFAULT is bumped to 14 or later in https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.default-versions.mk

Installation: add xcb-icccm and xcb-errors on FreeBSD

ad5329a

Installation: add hypr* dependencies on FreeBSD

f7cac02

hyprwm/Hyprland@13f6f0b923ff hyprwm/Hyprland@c3882bb83240 hyprwm/Hyprland@ea954494024c hyprwm/Hyprland@8c64a4bad710

Installation: drop wlroots leftovers on FreeBSD

2bfd293

hyprwm/Hyprland@016da234d0e8

Installation: add libuuid on FreeBSD

f6b0878

FreeBSD uuid(3) has slightly different API than Linux and doesn't support random UUIDs unlike NetBSD. Instead use external implementation. hyprwm/Hyprland@7778f01194d8

Installation: drop GNU make on FreeBSD

b914a77

hyprwm/Hyprland@c03dc47124ca

jbeich force-pushed the freebsd-install branch from 9c19d4f to b914a77 Compare September 21, 2024 14:55

vaxerski requested a review from fufexan September 21, 2024 15:37

fufexan reviewed Sep 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installation: improve FreeBSD instructions for Manual Build #200

Installation: improve FreeBSD instructions for Manual Build #200

jbeich commented Apr 25, 2023

vaxerski commented Apr 25, 2023

jbeich commented May 1, 2023 •

edited

Loading

fufexan commented Aug 11, 2023

jbeich commented Aug 11, 2023 •

edited

Loading

fufexan commented Aug 12, 2023

jbeich commented Nov 10, 2023

fufexan commented Nov 10, 2023

fufexan commented Jan 31, 2024

jbeich commented Jan 31, 2024

jbeich commented Jan 31, 2024

fufexan commented Jan 31, 2024

jbeich commented Sep 21, 2024

fufexan Sep 22, 2024

jbeich Sep 22, 2024

fufexan Sep 22, 2024

Installation: improve FreeBSD instructions for Manual Build #200

Are you sure you want to change the base?

Installation: improve FreeBSD instructions for Manual Build #200

Conversation

jbeich commented Apr 25, 2023

vaxerski commented Apr 25, 2023

jbeich commented May 1, 2023 • edited Loading

fufexan commented Aug 11, 2023

jbeich commented Aug 11, 2023 • edited Loading

fufexan commented Aug 12, 2023

jbeich commented Nov 10, 2023

fufexan commented Nov 10, 2023

fufexan commented Jan 31, 2024

jbeich commented Jan 31, 2024

jbeich commented Jan 31, 2024

fufexan commented Jan 31, 2024

jbeich commented Sep 21, 2024

fufexan Sep 22, 2024

Choose a reason for hiding this comment

jbeich Sep 22, 2024

Choose a reason for hiding this comment

fufexan Sep 22, 2024

Choose a reason for hiding this comment

jbeich commented May 1, 2023 •

edited

Loading

jbeich commented Aug 11, 2023 •

edited

Loading