fix test for node 20

hzrd149 · Jan 9, 2025 · aec45c6 · aec45c6
1 parent 0495fb9
commit aec45c6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,16 +11,22 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [20.x, 22.x]
+      fail-fast: false
+
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v4
 
       - uses: pnpm/action-setup@v4
 
-      - name: Setup Node.js 20
+      - name: Setup Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: ${{ matrix.node-version }}
           cache: "pnpm"
 
       - name: Install Dependencies

diff --git a/packages/signer/src/signers/amber-clipboard-signer.ts b/packages/signer/src/signers/amber-clipboard-signer.ts
@@ -10,7 +10,11 @@ import { Nip07Interface } from "../nip-07.js";
  */
 export class AmberClipboardSigner implements Nip07Interface {
   /** If the signer is supported on this platform */
-  static SUPPORTED = navigator.userAgent.includes("Android") && navigator.clipboard && navigator.clipboard.readText;
+  static SUPPORTED =
+    `navigator` in globalThis &&
+    navigator.userAgent.includes("Android") &&
+    navigator.clipboard &&
+    navigator.clipboard.readText;
 
   private pendingRequest: Deferred<string> | null = null;
   public pubkey?: string;

diff --git a/packages/signer/src/signers/serial-port-signer.ts b/packages/signer/src/signers/serial-port-signer.ts
@@ -70,7 +70,7 @@ export class SerialPortSigner implements Nip07Interface {
   }
 
   async connectToDevice({ onConnect, onDisconnect, onError, onDone }: DeviceOpts): Promise<void> {
-    let port: SerialPort = await navigator.serial.requestPort();
+    let port: SerialPort = await window.navigator.serial.requestPort();
     let reader;
 
     const startSerialPortReading = async () => {
@@ -255,7 +255,7 @@ export class SerialPortSigner implements Nip07Interface {
   }
 
   // static const
-  static SUPPORTED = !!navigator.serial;
+  static SUPPORTED = "navigator" in globalThis && !!navigator.serial;
 
   static METHOD_PING = "/ping";
   static METHOD_LOG = "/log";