-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List report.html files on job result page #33
Conversation
@Peter9192 could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. Might be nice to replace this example with the example referred to here (or add that one)
app/components/ListReportFiles.tsx
Outdated
return ( | ||
<ul className="list-disc list-inside"> | ||
{htmlFiles.map(([module, htmls]) => { | ||
return <li key={module}><a target="_blank" rel="noreferrer" href={`${prefix}${htmls[0].path}`}>{module}</a></li>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does htmls
only ever contain 1 item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
Each caprieval analysis module has multiple html files, but only one report.html.
We only want to show report.html for now, later each plot in report.html could link to the single plot html file.
Changed code to use map<module,report path>
…nit test for ListReportFiles component.
Thanks for reviewing. For developers I was just interested in a workflow with had some report.html files and ran quickly. |
Refs #17
Once job has completed the job result page looks like
With links to report.html for each caprieval module analysis.
To test:
npm install
andnpm run dev
cp docking-antibody-antigen-ranairCDR-clt-test.cfg workflow.cfg
andzip -r docking-antibody-antigen-ranairCDR-clt-test.zip data workflow.cfg
13_caprieval_analysis
link to see analyis report.