Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List report.html files on job result page #33

Merged
merged 14 commits into from
May 31, 2023
Merged

List report.html files on job result page #33

merged 14 commits into from
May 31, 2023

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Apr 6, 2023

Refs #17

Once job has completed the job result page looks like
localhost_3000_jobs_1 (1)
With links to report.html for each caprieval module analysis.

To test:

  1. Setup bartender as instructed at https://github.com/i-VRESSE/bartended-haddock3#bartender-web-service-configuration
  2. Create user who has super powers and has guru expertise level, see https://github.com/i-VRESSE/bartender/blob/main/docs/user_management.md#super-user
  3. Start with npm install and npm run dev
  4. Create zip from https://github.com/haddocking/haddock3/blob/main/examples/docking-antibody-antigen/docking-antibody-antigen-ranairCDR-clt-test.cfg with cp docking-antibody-antigen-ranairCDR-clt-test.cfg workflow.cfg and zip -r docking-antibody-antigen-ranairCDR-clt-test.zip data workflow.cfg
  5. Either upload zip on http://localhost:3000/builder and submit
  6. Goto http://localhost:3000/jobs
  7. Wait for job to complete, reload page until you see state is ok or error.
  8. Page should look similar to screenshot above.
  9. Click on 13_caprieval_analysis link to see analyis report.

@sverhoeven sverhoeven changed the title Page to show report.html files List report.html files on job result page Apr 6, 2023
@sverhoeven sverhoeven requested a review from Peter9192 April 6, 2023 15:14
@sverhoeven sverhoeven marked this pull request as ready for review April 6, 2023 15:14
@sverhoeven
Copy link
Member Author

@Peter9192 could you review this PR?

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Might be nice to replace this example with the example referred to here (or add that one)

return (
<ul className="list-disc list-inside">
{htmlFiles.map(([module, htmls]) => {
return <li key={module}><a target="_blank" rel="noreferrer" href={`${prefix}${htmls[0].path}`}>{module}</a></li>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does htmls only ever contain 1 item?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.
Each caprieval analysis module has multiple html files, but only one report.html.
We only want to show report.html for now, later each plot in report.html could link to the single plot html file.

Changed code to use map<module,report path>

@sverhoeven
Copy link
Member Author

Thanks for reviewing.

For developers I was just interested in a workflow with had some report.html files and ran quickly.
I could have also suggested to use the zip file, but then you dont know how it was made.
Scientifically relevant workflows will be handled in #29 .

@sverhoeven sverhoeven merged commit 3c86fc0 into main May 31, 2023
@sverhoeven sverhoeven deleted the result-viewer branch May 31, 2023 12:10
@sverhoeven sverhoeven mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants