Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dasiyui with shadcn/ui #73

Merged
merged 42 commits into from
Feb 14, 2024
Merged

Replace dasiyui with shadcn/ui #73

merged 42 commits into from
Feb 14, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Feb 2, 2024

Refs #48

TODO

  • Header / Footer
  • Navbar
    • Moves when page toggles scrollbar
    • use local banner.jpg
    • highlight when active
  • Builder
  • only use css variables for colors
  • Upload
  • Report / Browse
  • Profile
  • User admin
  • Login / register
  • Dark mode, https://ui.shadcn.com/docs/dark-mode/remix
  • Remove css classes without implementation like btn

The plots do not adapt to dark mode.
Has to be done in python with plotly_dark theme
Rendering each plot in light and dark theme seems a bit much. So for now we show plots always with white background.

Also the rendering the toml in the builder uses a hardcoded style which is always light.

sverhoeven and others added 30 commits February 2, 2024 14:33
TODO
* tables
* builder
TODO

* jobs table
* caprieval
  * table always follows system pref
  * plot always white
Gets rid of stddev when it is 0
@sverhoeven sverhoeven marked this pull request as ready for review February 8, 2024 14:47
@sverhoeven sverhoeven requested a review from dmijatovic February 8, 2024 14:47
Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sverhoeven sverhoeven merged commit ed1f371 into main Feb 14, 2024
1 check passed
@sverhoeven sverhoeven deleted the daisyui2shadcnui branch February 14, 2024 10:36
@sverhoeven sverhoeven mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants