Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passive active choice #98

Merged
merged 28 commits into from
May 10, 2024
Merged

Passive active choice #98

merged 28 commits into from
May 10, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Apr 23, 2024 •
edited
Loading

Fixes #97

0 0 0 0_3000_scenarios_protein-protein
0 0 0 0_3000_scenarios_protein-protein (1)

TODO

  • render active passive checkboxes together in 2D sequence
  • copy to clipboard button
  • get shift select to work again
  • show neigbours as disabled passive in 2D sequence view
  • given passive selected residue then selecting that residue as active in 3D does not unselect passive
  • better name for RestraintsBase
  • sync docs/scenarios.md with code
  • allow user to change surface cutoff
  • toggle to show buried residues
  • use surface representation in 3D

Also adds:

sverhoeven and others added 22 commits April 23, 2024 09:06
@sverhoeven
Moved todos to #97
37d3560
@sverhoeven
Merge remote-tracking branch 'origin/main' into passive-active-choice
c719e34
@sverhoeven
Add storybook.js so components are easier to develop in isolation
bd251fa
@sverhoeven
Big refactor of molecule sub form and its children
4dafa24 
Also added copy to clipboard buttons to residue selections.
@sverhoeven
When mouse leaves ngl viewer make sure any highlighted residues are u…
62e8f32 
…nhighlighted
@sverhoeven
Active selection takes precedence over already selected passive
e3fff8b
@sverhoeven
Add toggle shadcn component
a5308c2
@sverhoeven
Save computed neigbours in own list
9f85728
@sverhoeven
get shift select to work again
db2dc5e
@sverhoeven
Picking 3D will unselect other
453c988 
Given passive seelected then picking active whill unselect passive.
And vice versa
@sverhoeven
Renamed RestraintsBase to RestraintsFlavour
ddfdfa2
@sverhoeven
Update docs
22b2597
@sverhoeven
Show neighbours as passive disabled residues
f0995a4
@sverhoeven
Regen restraints client dts
f97b44b
@sverhoeven
add default radius
bce0058
@sverhoeven
Use colors in 3D that are similar to colors of residue sequence
68d3ef1
@sverhoeven
User settable surface cutoff and neighbour radius
d5151e9
@sverhoeven
FOrmat
26860a3
@sverhoeven
Add toggle to show either surface or buried residues
e055e52
@sverhoeven
Added toggle to render selection as spacefill or surface
9697269
@sverhoeven
Show protein as surface
13e7dc5
@sverhoeven
Moved onPick + onHover to NGLStage
4a757bd
@sverhoeven sverhoeven marked this pull request as ready for review May 8, 2024 14:09
@sverhoeven sverhoeven merged commit 6fe9100 into main May 10, 2024
2 checks passed
@sverhoeven sverhoeven deleted the passive-active-choice branch May 10, 2024 08:33
@sverhoeven sverhoeven mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More active/passive residue choices
1 participant
@sverhoeven