Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(languageDetector): handle es-419 special case #65

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(languageDetector): handle es-419 special case #65

merged 1 commit into from
Oct 10, 2023

Conversation

orlando
Copy link
Contributor

@orlando orlando commented Oct 10, 2023 •
edited
Loading

Handle es-419 locale properly. Resolves #41

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 8c14bb4 into i18next:master Oct 10, 2023
5 checks passed
@adrai
Copy link
Member

adrai commented Oct 10, 2023

thank you, included in v3.4.1

@orlando orlando deleted the od/es-419-fix branch October 10, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detection regex fails with Spanish (Latin America) (es-419)
2 participants
@orlando @adrai