Compat: Make tests work on Windows with non-English locale #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
I originally started investigating the Broccoli problems mentioned in #684 on a Windows computer, running with some Danish locale settings. This caused a number of problems, from my editor opening bin/cli.js instead of running the code to sorting and line-ending issues with some tests.
Assuming the assertions to be the one source of truth, I've added a locale parameter in localeCompare for the default comparison function. lineEndings are set to
lffor a test that checks the entire contents of a generated JSON file.Does it fix an existing ticket?
No
Checklist
yarn test(see details here)