Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule file path is always prefixed with "origin prefix" in 2.5.4 #103

Open
kentxu opened this issue Jan 12, 2023 · 0 comments
Open

rule file path is always prefixed with "origin prefix" in 2.5.4 #103

kentxu opened this issue Jan 12, 2023 · 0 comments

Comments

@kentxu
Copy link

kentxu commented Jan 12, 2023

Upgrading from 2.4.1, I noticed all the reroute rules defined in the rule file stopped working.

S3 access log shows the rule file path from Middy Reroute is now prefixed with any prefix defined in the origin.
Here is an example:
const opts={
file: '_redirects/rule1",
rulesBucket: "bucket1"
}

origin is defined as "bucket1/sites"

In 2.4.1, the rule path used is "bucket1/_redirects/rule1"
in 2.5.4, the rule path used is "bucket1/sites/_redirects/rule1"

Is this a bug? The documentation seems to suggest the optional "rulesBucket" and "file" options should form the complete s3 path regardless how the origin is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant