Merge from master #453
Merged
Merge from master #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu_3/make_spiral/solution.py:59:13: R0916: Too many boolean expressions in if statement (6/5) (too-many-boolean-expressions)
kyu_3/make_spiral/solution.py:97:8: R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break)
kyu_3/make_spiral/solution.py:133:8: R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break)
kyu_3/line_safari_is_that_a_line/walker_class.py:157:4: R0912: Too many branches (17/12) (too-many-branches)
kyu_3/calculator/calculator.py:13:0: R0903: Too few public methods (1/2) (too-few-public-methods)
kyu_3/calculator/calculator.py:13:0: R0903: Too few public methods (1/2) (too-few-public-methods)
Line too long (86 > 79 characters) New
Line too long (91 > 79 characters) New
Function check_submarine has 5 arguments (exceeds 4 allowed). Consider refactoring. New
Consider simplifying this complex logical expression
Consider simplifying this complex logical expression
merge from master
kyu_4/snail/test_snail.py:47:0: C0301: Line too long (101/100) (line-too-long)
kyu_4/snail/test_snail.py:30:0: C0115: Missing class docstring (missing-class-docstring)
************ Module kyu_4.snail.snail_sort kyu_4/snail/snail_sort.py:22:15: R1734: Consider using [] instead of list() (use-list-literal) kyu_4/snail/snail_sort.py:24:13: R1734: Consider using [] instead of list() (use-list-literal)
************* Module kyu_4.sum_by_factors.sum_for_list kyu_4/sum_by_factors/sum_for_list.py:24:14: R1734: Consider using [] instead of list() (use-list-literal) kyu_4/sum_by_factors/sum_for_list.py:32:21: R1734: Consider using [] instead of list() (use-list-literal)
************* Module kyu_4.sum_by_factors.test_sum_for_list kyu_4/sum_by_factors/test_sum_for_list.py:71:0: C0301: Line too long (102/100) (line-too-long) kyu_4/sum_by_factors/test_sum_for_list.py:80:29: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) kyu_4/sum_by_factors/test_sum_for_list.py:11:0: C0411: standard import "unittest" should be placed before third party import "allure" (wrong-import-order)
************* Module kyu_4.most_frequently_used_words.test_top_3_words kyu_4/most_frequently_used_words/test_top_3_words.py:11:0: C0411: standard import "unittest" should be placed before third party import "allure" (wrong-import-order)
************* Module kyu_4.most_frequently_used_words.solution
kyu_4/most_frequently_used_words/solution.py:29:21: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal)
kyu_4/most_frequently_used_words/solution.py:39:20: R1734: Consider using [] instead of list() (use-list-literal)
==kyu_4.the_greatest_warrior.test_battle:[15:30] ==kyu_4.the_greatest_warrior.test_warrior:[16:31]
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/449/kyu_5/find_the_smallest/solution.py:docstring of kyu_5.find_the_smallest.solution.smallest:6: WARNING: Enumerated list ends without a blank line; unexpected unindent. /home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/449/kyu_5/sports_league_table_ranking/test_compute_ranks.py:docstring of kyu_5.sports_league_table_ranking.test_compute_ranks.ComputeRanksTestCase.test_something:10: WARNING: Bullet list ends without a blank line; unexpected unindent.
/kyu_5/find_the_smallest
ikostan
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.