Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for emoji_contains_emoji #35

Open
charlesverge opened this issue Jul 3, 2017 · 1 comment
Open

False positives for emoji_contains_emoji #35

charlesverge opened this issue Jul 3, 2017 · 1 comment

Comments

@charlesverge
Copy link

The using emoji_contains_emoji I noticed a number of maybe false positives, it's up for debate as you could use many of these symbols as emoji. Since I was working with a larger source of user generated content I opted to retrieve valid sources of emoji and Unicode characters. The following is the test scripts.
https://github.com/charlesverge/emoji-php-comparsion

Two examples are

Detected as emoji ⤂

Not detected 3️⃣ as emoji

Not sure if any thing should be changed other than adding a few more emoji into the data set as the false positives for the most part look fine as emoji.

@chandon
Copy link

chandon commented Feb 18, 2019

even ’ is detected as emoji ! Analyzing prefix is not enough, the whole emoji should match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants