Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slate-drop-or-paste-image breaks default drag&drop #8

Open
SynnaxCrab opened this issue Nov 8, 2017 · 2 comments
Open

slate-drop-or-paste-image breaks default drag&drop #8

SynnaxCrab opened this issue Nov 8, 2017 · 2 comments

Comments

@SynnaxCrab
Copy link

Do you want to request a feature or report a bug?

Bug

What's the current behavior?

1

uncaught TypeError: Failed to execute 'readAsDataURL' on 'FileReader': parameter 1 is not of type 'Blob'.
    at Image.load (build.prod.js:582)
    at Image.componentDidMount (build.prod.js:571)
    at CallbackQueue.notifyAll (build.prod.js:17008)
    at ReactReconcileTransaction.close (build.prod.js:26887)
    at ReactReconcileTransaction.closeAll (build.prod.js:29742)
    at ReactReconcileTransaction.perform (build.prod.js:29689)
    at ReactUpdatesFlushTransaction.perform (build.prod.js:29676)
    at ReactUpdatesFlushTransaction.perform (build.prod.js:27796)
    at Object.flushBatchedUpdates (build.prod.js:27879)
    at ReactDefaultBatchingStrategyTransaction.closeAll (build.prod.js:29742)

What's the expected behavior?

drag and drop should work by default.

@yanndavin
Copy link

Facing the same issue I've committed a simple fix which is may be not optimal (splitted blocks created during the first image copy are not merged after the drag & drop) but seems to fix the problem for simple cases. Hope this helps
https://github.com/yanndavin/slate-plugins/commit/03d44de28e40b5928216e06e8516afc3f4e01e88

@willbryk720
Copy link

Has there been any update on this? Is there a way to know when you are dragging within the doc as opposed to dragging from outside it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants