Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tsc-alias for nodenext compatibility #1232

Closed
wants to merge 2 commits into from

Conversation

Jakeii
Copy link

@Jakeii Jakeii commented May 3, 2024

Use tsc-alias to add file extensions to type definitions for compatibility with NodeNext

@Jakeii Jakeii marked this pull request as ready for review May 3, 2024 18:32
@arturmuller
Copy link
Collaborator

Hi @Jakeii — thank you so much for your PR!

I tested this locally, and unfortunately it doesn't seem to actually fix our issue.

Our core problem is with types declarations, not actual source code (since that's bundled and therefore there are no imports) and I am not sure if tsc-alias actually hooks into that.

Please lmk if you're still interested in trying to get this up and running.

@yeoffrey managed to unblock us by moving over to Vitest so the road to NodeNext compat has been cleared and this is not blocking for the release (any more).

Either way — thank you so much for the contrib! 🙌

@arturmuller arturmuller added the ⚑ pending Pull requests that are waiting on something else label Jun 20, 2024
@arturmuller
Copy link
Collaborator

@Jakeii I am going to close this for now, but if you feel like taking another crack at removing the .js extensions from our import paths in typedefs a PR is very welcome!

@arturmuller arturmuller closed this Jul 3, 2024
@Jakeii
Copy link
Author

Jakeii commented Jul 3, 2024

Hi @arturmuller, the tsc-alias plugin removes the need to add js extensions in ts source files, it adds them for you in both the generated js and d.ts files.

I did test locally and in worked for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚑ pending Pull requests that are waiting on something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants