IBX-9169: Add the ContentName criterion handler to trash handler
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
reviewed
Nov 4, 2024
| @@ -78,6 +78,7 @@ services: | |||
| tags: | |||
| - { name: ibexa.search.legacy.gateway.criterion_handler.content } | |||
| - { name: ibexa.search.legacy.gateway.criterion_handler.location } | |||
| - { name: ibexa.search.legacy.trash.gateway.criterion.handler } | |||
There was a problem hiding this comment.
AFAICS you need to add test coverage for it via \Ibexa\Tests\Core\Persistence\Legacy\TestCase::getTrashCriteriaConverterDependency.
Haven't touched this in a while. Hopefully nothing explodes 🤞
Please see how it's used and if anything else is needed there
There was a problem hiding this comment.
Thanks for catching that.
It's used as part of Location\Gateway for listing and counting trash items and therefore by TrashService. I suspect TrashService would explode immediately if there were any issues with it.
|
konradoboza
approved these changes
Nov 4, 2024
tbialcz
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/admin-ui#1388