Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9169: Add the ContentName criterion handler to trash handler #448

Open
wants to merge 2 commits into
base: 4.6
Choose a base branch
from
Open

IBX-9169: Add the ContentName criterion handler to trash handler #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8006353
IBX-9169: Add the `ContentName` criterion handler to trash handler
barw4 Nov 4, 2024
369096a
IBX-9169: Update `TestCase`
barw4 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/Resources/settings/search_engines/legacy/criterion_handlers_common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ services:
tags:
- { name: ibexa.search.legacy.gateway.criterion_handler.content }
- { name: ibexa.search.legacy.gateway.criterion_handler.location }
- { name: ibexa.search.legacy.trash.gateway.criterion.handler }
Copy link
Member

@alongosz alongosz Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS you need to add test coverage for it via \Ibexa\Tests\Core\Persistence\Legacy\TestCase::getTrashCriteriaConverterDependency.

Haven't touched this in a while. Hopefully nothing explodes 🤞

Please see how it's used and if anything else is needed there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that.

It's used as part of Location\Gateway for listing and counting trash items and therefore by TrashService. I suspect TrashService would explode immediately if there were any issues with it.


Ibexa\Core\Search\Legacy\Content\Common\Gateway\CriterionHandler\ContentTypeGroupId:
parent: Ibexa\Core\Search\Legacy\Content\Common\Gateway\CriterionHandler
Expand Down
1 change: 1 addition & 0 deletions tests/lib/Persistence/Legacy/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ protected function getTrashCriteriaConverterDependency(): CriteriaConverter
new CriterionHandler\ContentTypeId($connection),
new CriterionHandler\DateMetadata($connection),
new CriterionHandler\UserMetadata($connection),
new CriterionHandler\ContentName($connection),
]
);
}
Expand Down
Loading