Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazinga usage #2500

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix bazinga usage #2500

wants to merge 3 commits into from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Sep 19, 2024

Question Answer
JIRA Ticket
Versions
Edition

bazinga must generate the translations in the ./public/assets directory, not the ./assets directory.
It also means that removing ./assets doesn't remove translations.

composer run post-update-cmd is clearing the cache, and is running bazinga and yarn. It's the best way to get the translations working.

See composer.json script using bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains: https://github.com/ibexa/recipes/blob/master/ibexa/oss/4.6/manifest.json#L94

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

bazinga must generate the translations in the ./public/assets directory, not the ./assets directory.

See composer.json script using `bazinga:js-translation:dump %PUBLIC_DIR%/assets --merge-domains`

https://github.com/ibexa/recipes/blob/master/ibexa/oss/4.6/manifest.json#L94
php bin/console bazinga:js-translation:dump assets --merge-domains
php bin/console bazinga:js-translation:dump public/assets --merge-domains
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's not related to ./assets anymore and shouldn't be mentioned as a note…

@adriendupuis adriendupuis changed the title Fix bazinga:js-translation:dump path Fix bazinga usage Sep 23, 2024
@@ -30,7 +30,7 @@ If your browser language is set to French, the Back Office will be displayed in

`ibexa.system.<siteaccess>.user_preferences.additional_translations: ['pl_PL', 'fr_FR']`

Then, run `composer run post-update-cmd` and clear the cache.
Then, run `composer run post-update-cmd` which include a cache clear.
Copy link
Contributor Author

@adriendupuis adriendupuis Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayne cache:clear for other SiteAccesses than the default one?

Suggested change
Then, run `composer run post-update-cmd` which include a cache clear.
Then, run `composer run post-update-cmd` and `php bin/console cache:clear --siteaccess=admin`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant