Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formating #142

Merged
merged 19 commits into from
Jan 15, 2024
Merged

Code formating #142

merged 19 commits into from
Jan 15, 2024

Conversation

GonozalIX
Copy link

No description provided.

@RKrahl
Copy link
Member

RKrahl commented Nov 29, 2023

I don't quite get the logic behind the ordering of the imports applied here. IMHO, the most logic ordering would arrange the imports in four blocks:

  1. all imports from Java SE, e.g. from the java.* and javax.* namespace,
  2. all imports from the jakarta.* namespace,
  3. all other imports from third party libraries,
  4. finally, all imports from the org.icatproject.* namespace.

The blocks should be separated by one empty line. Within the blocks, the imports should be ordered lexicographically.

@RKrahl RKrahl added the internal Refactoring or changes that are supposed not to change the behavior label Nov 29, 2023
@RKrahl RKrahl changed the base branch from v3 to master November 30, 2023 15:40
Copy link
Member

@RKrahl RKrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this! I'm mostly happy with the result. But I do have a few nitpicking comments, though.

miredot.htmlintro.html Show resolved Hide resolved
miredot.htmlintro.html Show resolved Hide resolved
src/site/resources/css/site.css Show resolved Hide resolved
src/main/java/org/icatproject/ids/IdsBean.java Outdated Show resolved Hide resolved
src/main/java/org/icatproject/ids/IdsBean.java Outdated Show resolved Hide resolved
src/test/resources/DataSelectionDevTest.properties Outdated Show resolved Hide resolved
src/test/resources/one.properties Outdated Show resolved Hide resolved
src/test/resources/test.properties Outdated Show resolved Hide resolved
src/test/resources/two.properties Outdated Show resolved Hide resolved
src/test/resources/twodf.properties Show resolved Hide resolved
@RKrahl RKrahl merged commit 0c4695a into master Jan 15, 2024
2 checks passed
@RKrahl RKrahl deleted the code_formating branch January 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Refactoring or changes that are supposed not to change the behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants