Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include latest lat/lon based definition for forecast outputs #45

Closed
bnubald opened this issue Jul 9, 2024 · 3 comments · Fixed by #46
Closed

Include latest lat/lon based definition for forecast outputs #45

bnubald opened this issue Jul 9, 2024 · 3 comments · Fixed by #46
Assignees
@bnubald
Milestone
v0.2.9

Comments

@bnubald
Copy link
Contributor

bnubald commented Jul 9, 2024 •
edited
Loading

Update produce_op_forecasts.sh to allow new lat/lon based region and north-facing plot arguments via this script as introduced in this PR icenet-ai/icenet#282.

https://github.com/icenet-ai/icenet/blob/9a70ce688e1196aaebf60df5829e5fbb722f32c5/icenet/plotting/forecast.py#L1393-L1401
@bnubald bnubald self-assigned this Jul 9, 2024
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Jul 9, 2024
@bnubald
Fixes icenet-ai#45: Add lat/lon region forecast out script, add help
2e62518
bnubald added a commit that referenced this issue Jul 9, 2024
@bnubald
Merge pull request #46 from bnubald/45_north_facing_script_update
35ee3c4 
Fixes #45: Add lat/lon region forecast out script, add help
@bnubald bnubald linked a pull request Jul 9, 2024 that will close this issue
Fixes #45: Add lat/lon region forecast out script, add help #46
Merged
@bnubald bnubald closed this as completed Jul 9, 2024
@bnubald bnubald reopened this Jul 9, 2024
@bnubald
Copy link
Contributor Author

bnubald commented Jul 9, 2024

While icenet-ai/icenet#283 is not fixed, the script should avoid attempting to output metric plots when lat/lon region bounds are specified, which are not currently implemented for metric computation.

Hence, as it stands, these metric plot outputs are based on either pan-Arctic or pan-Antarctic rather than user defined lat/lon region.

Add logic to skip these outputs for now.

bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Jul 9, 2024
@bnubald
Dev icenet-ai#45: Skip metrics if using lat/lon region bounds
a9efede
@bnubald bnubald mentioned this issue Jul 9, 2024
Merged
bnubald added a commit that referenced this issue Jul 9, 2024
@bnubald
Merge pull request #48 from bnubald/45_north_facing_script_update
71835b6 
Dev #45 north facing script update
@bnubald
Copy link
Contributor Author

bnubald commented Jul 9, 2024

Resolved by above PR.

@bnubald bnubald closed this as completed Jul 9, 2024
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Switch from north facing to CRS definition, help up…
647e992 
…dates

Also add flag to not clip source data when defining a lat/lon region
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Fix getopts order, update help
e2bbcd0
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Enable user-specified max leadtime for forecast gen…
4bc56c7 
…eration
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Remove redundant ffmpeg png to mp4 video generation
9ca6692
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Update and simplify forecast output directory struc…
db8b791 
…ture
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Switch back to lon_min,lat_min... from lat_min,lon_…
3f82d8f 
…min,... region input
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Aug 1, 2024
@bnubald
Dev icenet-ai#45: Update produce_op_assets.sh help display
131193f
@bnubald bnubald reopened this Aug 1, 2024
@bnubald
Copy link
Contributor Author

bnubald commented Aug 1, 2024

Wanting to opt for user-specified Coordinate Reference System (CRS) instead of hard coding the CRS to use, want to allow specifying it when running the produce_op_forecasts.sh script.

@bnubald bnubald mentioned this issue Aug 1, 2024
Merged
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Dec 31, 2024
@bnubald
Dev icenet-ai#45: Update forecast output script for icenet updates
947a82b
@bnubald bnubald added this to the v0.2.9 milestone Dec 31, 2024
@bnubald bnubald closed this as completed Dec 31, 2024
bnubald added a commit that referenced this issue Dec 31, 2024
@bnubald
Merge pull request #52 from bnubald/45_reprojection_crs_plots
131a23b 
Resolves #45: Allow generic CRS definition for plotting
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Jan 6, 2025
@bnubald
Dev icenet-ai#45: Include region argument details in forecast output …
64d2095 
…dir path
bnubald added a commit to bnubald/icenet-pipeline that referenced this issue Jan 7, 2025
@bnubald
Dev icenet-ai#45: Include region argument details in forecast output …
f6eb2a3 
…dir path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnubald bnubald

Labels
None yet
Projects
None yet
Milestone
v0.2.9
Development

Successfully merging a pull request may close this issue.

Fixes #45: Add lat/lon region forecast out script, add help bnubald/icenet-pipeline
1 participant
@bnubald