Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary 1.19 merge to master #416

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Dictionary 1.19 merge to master #416

merged 11 commits into from
Oct 19, 2023

Conversation

hknahal
Copy link
Contributor

@hknahal hknahal commented Sep 22, 2023

hknahal and others added 10 commits November 25, 2022 17:26
* Regex w/ Unit Tests

* Remove Logging

* Move to Common

* Revise Shared Logic, Add PD Test
… 'Xenograft - derived from metastatic tumour') to 'specimen_type' codelist
Added new term 'physician assessed progressive disease' to 'Physican Assessed Response Criteria' codelist
Added two new terms ('Cell line - derived from metastatic tumour' and  'Xenograft - derived from metastatic tumour') to 'specimen_type' codelist
Added optional field in Donor schema for lost to follow up
@hknahal
Copy link
Contributor Author

hknahal commented Sep 22, 2023

Was able to successfully register two tumour specimens using the 2 new specimen_type terms:
new_specimen_type_terms

@hknahal
Copy link
Contributor Author

hknahal commented Sep 22, 2023

Validation of incorrect IDs fails as expected. Returns an error indicating the submitted IDs do not conform to required regex:

test-ca_sample_reg_error_incorrect_ids

@hknahal
Copy link
Contributor Author

hknahal commented Sep 22, 2023

@hknahal hknahal self-assigned this Sep 27, 2023
@hknahal
Copy link
Contributor Author

hknahal commented Oct 17, 2023

All test cases in icgc-argo/argo-clinical#854 were tested in DEV and QA and pass or fail validation as expected.

@hknahal hknahal merged commit e99877c into master Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants