Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Entity: Updates for first release #2090

Closed
23 tasks done
kcullion opened this issue Oct 20, 2021 · 6 comments
Closed
23 tasks done

File Entity: Updates for first release #2090

kcullion opened this issue Oct 20, 2021 · 6 comments
Assignees
Labels

Comments

@kcullion
Copy link

kcullion commented Oct 20, 2021

We need to make some changes to the File Entity page so that

  1. We can release a first version, while we work on clinical additions
  2. It's consistent with the data in the file repository
    (I confirmed all of the field label changes and additions with Hardeep and Linda)

Zeplin: https://zpl.io/an8jpLl

Field Label Updates for consistency

Hook Up the following fields

  • 6. Hook up File ID in the title bar instead of the longer Object ID
  • 7. File ID in the table
  • 8. Program - this may be coming from program services - but can we display the full name of the program then the Program ID in brackets. (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)
  • 9. Data Type
  • 10. Genome Build ; Linda says this will stay as GRCh38 only for a while. (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)
  • 11. Analysis Tools (this used to be called Software) - also this can have multiple values so display in the table cell as comma separated.
  • 12. Submitted Donor ID
  • 13. Hook up Matched Normal Submitter Sample ID (this will just be for tumours)

Add and hookup

  • 14. Add Data Category and hookup
  • 15. Add Genome Annotation and hookup.
    NOTE this will only be populated for RNA-Seq data, and N/A otherwise. We currently don't have an RNA pipeline, so this field will be N/A for all current files.
  • 16. Add Workflow Version and hookup (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)
  • 17. Add Specimen Type and hookup
    image

Hide/Remove

  • 18. Hide the File download button in top header
    NOTE: The legend component will be described in this ticket: https://github.com/icgc-argo/platform-ui/issues/2108
  • 19. Hide the Donor tabs, a file will only be associated to one donor for now.
  • 20. Remove all links in the Associated Donors card (donor id, specimen id, sample id, matched normal id links)
  • 21. Hide the clinical fields under the donor IDs: Primary Site, Cancer Type and Age at Diagnosis
  • 22. If Tumour Normal Designation: Normal then hide Matched Normal Submitter Sample ID AND the divider line.
    image
@kcullion kcullion transferred this issue from icgc-argo/roadmap Oct 20, 2021
@kcullion kcullion changed the title File Entity page updates for first release File Entity: Updates for first release Oct 20, 2021
@kcullion
Copy link
Author

@mistryrn @akachru-github I think once this ticket is finished it would make sense to do this related one before getting to the small file download tickets
#2105

@kcullion
Copy link
Author

kcullion commented Dec 2, 2021

@mistryrn as discussed, let me know when you need the opened lock logo - this will be the icon to show for File Access = Open

@mistryrn
Copy link
Contributor

mistryrn commented Dec 9, 2021

Re: "Open Lock" icon

The icon will be temporarily added directly to the page in platform-ui while we wait for the new UIKit to be ready.

Once it's ready, the icon will be added to UIKit in icgc-argo/uikit#26 and we will switch to using the new UIKit icon on this page here #2136

mistryrn added a commit that referenced this issue Dec 14, 2021
* Update labels, add new fields, and connect pre-existing fields to new API values
mistryrn added a commit that referenced this issue Dec 15, 2021
💄 Updates to File Entity Page for First Release (#2090)
@akachru-github akachru-github removed this from the Donkey Kong Sprint 64 milestone Dec 16, 2021
@mistryrn
Copy link
Contributor

@kcullion the items which aren't checked are going to be addressed in #2105

@kcullion
Copy link
Author

This looks great @mistryrn !
I'm going to add one piece of feedback to the continuation ticket: #2105

I would like Linda to test this page too to make sure all the data is looking correct - but I'll wait to ask her on that 2105 ticket too.

@kcullion
Copy link
Author

kcullion commented Feb 8, 2022

this page is working as expected in staging

@kcullion kcullion closed this as completed Feb 9, 2022
mistryrn added a commit to icgc-argo/uikit that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants