-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Entity: Updates for first release #2090
Comments
@mistryrn @akachru-github I think once this ticket is finished it would make sense to do this related one before getting to the small file download tickets |
@mistryrn as discussed, let me know when you need the opened lock logo - this will be the icon to show for |
Re: "Open Lock" icon The icon will be temporarily added directly to the page in Once it's ready, the icon will be added to UIKit in icgc-argo/uikit#26 and we will switch to using the new UIKit icon on this page here #2136 |
* Update labels, add new fields, and connect pre-existing fields to new API values
💄 Updates to File Entity Page for First Release (#2090)
this page is working as expected in staging |
* Adds the "Open Lock" icon for icgc-argo/platform-ui#2090
We need to make some changes to the File Entity page so that
(I confirmed all of the field label changes and additions with Hardeep and Linda)
Zeplin: https://zpl.io/an8jpLl
Field Label Updates for consistency
File Format
toFile Type
Size
toFile Size
Access
toFile Access
Workflow Type
toWorkflow Name
(link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)Software
toAnalysis Tools
File Access=Open
, let's change the icon to an unlocked iconHook Up the following fields
File ID
in the title bar instead of the longerObject ID
File ID
in the tableProgram
- this may be coming from program services - but can we display the full name of the program then theProgram ID
in brackets. (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)Data Type
Genome Build
; Linda says this will stay as GRCh38 only for a while. (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)Analysis Tools
(this used to be called Software) - also this can have multiple values so display in the table cell as comma separated.Submitted Donor ID
Matched Normal Submitter Sample ID
(this will just be for tumours)Add and hookup
Data Category
and hookupGenome Annotation
and hookup.NOTE this will only be populated for
RNA-Seq
data, andN/A
otherwise. We currently don't have an RNA pipeline, so this field will be N/A for all current files.Workflow Version
and hookup (link details are outlined in File Entity: First release field links and Sequencing Read Properties #2105)Specimen Type
and hookupHide/Remove
NOTE: The legend component will be described in this ticket: https://github.com/icgc-argo/platform-ui/issues/2108
Primary Site
,Cancer Type
andAge at Diagnosis
Tumour Normal Designation
: Normal then hideMatched Normal Submitter Sample ID
AND the divider line.The text was updated successfully, but these errors were encountered: