Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable consistent styling #16

Open
ciaranschutte opened this issue Dec 1, 2021 · 1 comment
Open

Enable consistent styling #16

ciaranschutte opened this issue Dec 1, 2021 · 1 comment
Assignees

Comments

@ciaranschutte
Copy link
Contributor

ciaranschutte commented Dec 1, 2021

Several components prohibit styling due to missing props.
There are conflicting usages of how we are styling which need to be made consistent.
Some rough edges to address also eg. need all colour codes defined.

Detailed Description

  • ensure components have either a strictly defined set of props to customise or allow theme to be re-styled (don't just ...spread everything)
  • documentation on how to approach styling
    • check for colours consts, use styled over inline css
    • some components we should define strict interface others (containers) we should allow to be customised.
    • output of this should be a wiki page
  • make sure all colours are in the theme (involve Kim in the colour scheme process)
@ciaranschutte ciaranschutte changed the title Style Enable consistent styling Dec 1, 2021
@akachru-github akachru-github added this to the Donkey Kong Sprint 64 milestone Dec 2, 2021
@akachru-github akachru-github removed this from the Donkey Kong Sprint 65 milestone Dec 16, 2021
@ciaranschutte
Copy link
Contributor Author

an upgrade to latest Emotion package could be worth while here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants