Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libpfm4 to Commit e21e89 #235

Merged

Conversation

Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Sep 9, 2024

Pull Request Description

Current with
commit 9c5c88e734e866f0801b80c527330ad6dbe21e89
Author: Stephane Eranian eranian@gmail.com
Date: Tue Sep 10 23:58:35 2024 -0700

  add ARM Cortex A72 Core PMU support

  As a clone of Cortex A57.

  Signed-off-by: Stephane Eranian <eranian@gmail.com>

commit 6d276b48eba5ead4e3fd4b6eca359504f2b69b6c
Author: Ian Rogers irogers@google.com
Date: Mon Sep 9 09:22:50 2024 -0700

fix pfm_arm_detect() buffer initialization problem

Commit 3abda5bc6c1a ("Optimize pfm_detect() for ARM processors")
added an optimization to avoid parsing /proc/cpuinfo too many times.
But it had a bug whereby it was reinitializing the pfm_arm_cfg.*
fields multiple times and potentially from an uninitialized buffer.

Signed-off-by: Ian Rogers <irogers@google.com>

commit fd3191c34ad87e22d3f3d31d2cf5c1050a9136ba
Author: Stephane Eranian eranian@gmail.com
Date: Thu Sep 5 23:38:53 2024 -0700

 Fix FRONTEND_RETIRED.LATE_SWPF encoding on Intel GNR

 Fix was missing from commit d799b554647 ("update Intel GraniteRapids core PMU to 1.03")

 Signed-off-by: Stephane Eranian <eranian@gmail.com>

Note: As stands the PAPI team does not have access to a machine with either, Intel Granite Rapids or ARM Cortex A72 to test the updated changes mentioned above.

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess Treece-Burgess changed the title Update libpfm4 to Commit b69b6c Update libpfm4 to Commit e21e89 Sep 12, 2024
Current with
commit 9c5c88e734e866f0801b80c527330ad6dbe21e89
Author: Stephane Eranian <eranian@gmail.com>
Date:   Tue Sep 10 23:58:35 2024 -0700

  add ARM Cortex A72 Core PMU support

  As a clone of Cortex A57.

  Signed-off-by: Stephane Eranian <eranian@gmail.com>

commit 6d276b48eba5ead4e3fd4b6eca359504f2b69b6c
Author: Ian Rogers <irogers@google.com>
Date:   Mon Sep 9 09:22:50 2024 -0700

  fix pfm_arm_detect() buffer initialization problem

  Commit 3abda5bc6c1a ("Optimize pfm_detect() for ARM processors")
  added an optimization to avoid parsing /proc/cpuinfo too many times.
  But it had a bug whereby it was reinitializing the pfm_arm_cfg.*
  fields multiple times and potentially from an uninitialized buffer.

  Signed-off-by: Ian Rogers <irogers@google.com>

commit fd3191c34ad87e22d3f3d31d2cf5c1050a9136ba
Author: Stephane Eranian <eranian@gmail.com>
Date:   Thu Sep 5 23:38:53 2024 -0700

  Fix FRONTEND_RETIRED.LATE_SWPF encoding on Intel GNR

  Fix was missing from commit d799b554647 ("update Intel GraniteRapids core PMU to 1.03")

  Signed-off-by: Stephane Eranian <eranian@gmail.com>

Note: As stands the PAPI team does not have access to a machine with
either, Intel Granite Rapids or ARM Cortex A72 to test the updated
changes mentioned above.
@Treece-Burgess Treece-Burgess merged commit afeb059 into icl-utk-edu:master Sep 17, 2024
26 checks passed
willowec pushed a commit to willowec/papi-devel that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants